From: Takashi Iwai <tiwai@suse.de>
To: HyeongJun An <sammiee5311@gmail.com>
Cc: Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Shuah Khan <shuah@kernel.org>,
linux-sound@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] selftests/alsa: Catch writes that silently change other controls
Date: Sun, 04 Oct 2026 20:22:33 +0200 [thread overview]
Message-ID: <87ece5iavq.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260930111534.3782264-1-sammiee5311@gmail.com>
On Wed, 30 Sep 2026 13:15:32 +0200,
HyeongJun An wrote:
>
> Mark asked for this in the es8316 thread [1]: have mixer-test check
> for other controls changing when one is written. Patch 2 adds that.
>
> Patch 1 fixes a bug that testing patch 2 turned up. With a driver that
> notifies a neighbour with a value event, wait_for_event() returns on
> the neighbour's event and the next test reports a spurious one.
>
> The cost is two extra writes per control and a read of every other
> control on the card after each. On the two cards here, 39 controls in
> all, the run time does not move. I have no card with hundreds of
> controls to measure against the 45 second kselftest timeout.
>
> [1] https://lore.kernel.org/all/0fefbfe1-021b-46b2-8945-15956e75e37f@sirena.org.uk/
>
> HyeongJun An (2):
> selftests/alsa: Do not take another control's event as our own
> selftests/alsa: Check that a write does not silently change other
> controls
Applied both to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-10-04 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 11:15 [PATCH 0/2] selftests/alsa: Catch writes that silently change other controls HyeongJun An
2026-09-30 11:15 ` [PATCH 1/2] selftests/alsa: Do not take another control's event as our own HyeongJun An
2026-09-30 11:15 ` [PATCH 2/2] selftests/alsa: Check that a write does not silently change other controls HyeongJun An
2026-10-04 18:22 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ece5iavq.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sammiee5311@gmail.com \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.