From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45475CA5FA2 for ; Mon, 28 Sep 2026 12:23:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xBAOV-0002br-IN; Mon, 28 Sep 2026 08:23:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xBAOL-0002Wp-Kb for qemu-arm@nongnu.org; Mon, 28 Sep 2026 08:23:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xBAOJ-0007yX-OM for qemu-arm@nongnu.org; Mon, 28 Sep 2026 08:23:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790598210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kXgIVTB2IzRumv+Sh+U54waJwvhb8gGhS/ZAT5ZZ938=; b=JxfOcjoy70N8Lbx+RQ37UU9xfpbHqSIyspam+XACMtNwkdMkCgd8RaV1eMLYqe7VWvkW/k U2fk/p0mEWLVmL3dz4LaADmv6M0UiajvA32aCIvcX2ytQd6QwvtefJOy4YhxyJlMwNqY5n NYGIfAahaUUa4QqeJ6sbLjtsQuIiAd8= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-9BPSgMAsPBWSqjeAUsSSJA-1; Mon, 28 Sep 2026 08:23:27 -0400 X-MC-Unique: 9BPSgMAsPBWSqjeAUsSSJA-1 X-Mimecast-MFC-AGG-ID: 9BPSgMAsPBWSqjeAUsSSJA_1790598205 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 67B94195D03D; Mon, 28 Sep 2026 12:23:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.5]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C7C1C180036E; Mon, 28 Sep 2026 12:23:24 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 603B421E6A04; Mon, 28 Sep 2026 14:23:22 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: Yonggang Luo , qemu-devel@nongnu.org, Richard Henderson , Philippe =?utf-8?Q?Mathieu-Dau?= =?utf-8?Q?d=C3=A9?= , "Edgar E. Iglesias" , Pierrick Bouvier , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , Alistair Francis , Peter Maydell , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-arm@nongnu.org, kvm@vger.kernel.org Subject: Re: [PATCH v4 40/55] meson: link shared objects into qemu-system In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Mon, 28 Sep 2026 12:47:38 +0100") References: <20260926070057.1234-1-luoyonggang@gmail.com> <20260926070057.1234-41-luoyonggang@gmail.com> <8733uthabd.fsf@pond.sub.org> Date: Mon, 28 Sep 2026 14:23:22 +0200 Message-ID: <87ecedfttx.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-MFC-PROC-ID: QacXLSx_C9RKtKVtvGeejLRJr7bxNp9Dq1yxMHw323M_1790598205 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.238, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > On Mon, Sep 28, 2026 at 01:41:58PM +0200, Markus Armbruster wrote: >> Yonggang Luo writes: >>=20 >> > Extract common_ss, system_ss, and family-common objects into one >> > qemu-system binary. Only arm, aarch64, microblaze-softmmu are >> > listed; a new target must have arch_srcs equal to target_info_def >> > only (target-info-def.c). Config headers stay in arch_genh. >> > >> > - Union non-TARGET_* keys with y taking precedence >> > - Reject leftover arch_srcs on participating targets >> > - Reject TARGET_* conditions on common_ss and system_ss >> > - Link SDL, install the binary, and apply Darwin entitlements >> > >> > Adding a target that still has per-target sources fails meson, for >> > example: >> > >> > combined qemu-system leftover for : >> > expected: >> > target-info-def.c >> > arch_srcs: >> > target/microblaze/mmu.c >> > target/microblaze/machine.c >> > target-info-def.c >> > >> > Signed-off-by: Yonggang Luo >>=20 >> Watch query-target lie: >>=20 >> $ qemu-system -S -nodefaults -display none -qmp stdio >> {"QMP": {"version": {"qemu": {"micro": 50, "minor": 1, "major": 11},= "package": "v11.1.0-1902-g88f617913a"}, "capabilities": ["oob"]}} >> qemu-system: warning: nic xlnx.xps-ethernetlite.0 has no peer >> {"execute": "qmp_capabilities", "arguments": {"enable": ["oob"]}} >> {"return": {}} >> {'execute': 'query-target'} >> --> {"return": {"arch": "aarch64"}} >>=20 >> Perhaps you can fix this by reordering patches. If you can't, >> deficiencies like this one need a prominent mention in the commit >> message. > > What do you think the behaviour of 'query-target' ought to be in > this scenario ? > > The 'none' machine has no associated target. Should we add a > 'none' or 'unspecified' target to SysEmuTarget, or should we > just declare that "query-target" will report an error if no > target is activate. Both solutions could work. To have a preference, I'd have to think some more. Thinking costs extra! ;) For what it's worth, the next patch adds member "none" to SysEmuTarget. > I'd probably lean towards the latter. Latter in this series > is a new 'query-targets' command that can enumerate all > available targets in 'qemu-system', so 'query-target' merely > tells us which is active (if any). Perhaps 'query-targets' > should in fact tell us that straightaway, such that we can > declare 'query-target' to be obsolete (and even deprecate > it) > > With regards, > Daniel