All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Orgad Shaneh <orgads@gmail.com>
Cc: linux-mtd@lists.infradead.org,  linux-kernel@vger.kernel.org,
	richard@nod.at,  vigneshr@ti.com
Subject: Re: [PATCH v2] mtd: cfi_cmdset_0002: cap the write-buffer chunk at 256 bytes on an x8 device
Date: Thu, 17 Sep 2026 14:46:52 +0200	[thread overview]
Message-ID: <87ecesjb9f.fsf@bootlin.com> (raw)
In-Reply-To: <20260916162746.308008-1-orgads@gmail.com> (Orgad Shaneh's message of "Wed, 16 Sep 2026 16:27:45 +0000")

On 16/09/2026 at 16:27:45 GMT, Orgad Shaneh <orgads@gmail.com> wrote:

> Hi Miquel,
>
> Thanks for the review. v3 sent as a reply to v2.
>
>> This sentence does not mean anything, I'm sorry.
>
> Rewritten: the count goes out as a single bus word, CMD() replicates it
> into every device lane, and an x8 part reads it off eight data lines, so
> anything above 255 is truncated there.
>
>> failed? do you have hardware that actually triggered that issue?
>
> Yes - a Cavium Octeon CN6335 board whose NOR is an M29EW strapped to x8.
> The log in the commit message is from it, and the clamp fixes it. v3
> names the board.

Ok, this matters a lot to me today, because we get dozens and dozens of
hardening changes which do not always have an actual reality. If you fix
a real problem you encountered, that's relevant.

>
>> That's incorrect. It indicates until when we need to backport it.
>
> Added. I checked the code is really there: 1da177e4c3f4 already sends
> CMD(words - 1) and already takes the chunk size from MaxBufWriteSize.
>
> Vignesh is on To: for v3.

You should use checkpatch.pl or b4's option --auto-to-cc to create the Cc
list.

Thanks for the v3.

Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-09-17 12:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15  7:13 [PATCH] mtd: cfi_cmdset_0002: cap the write-buffer chunk at 256 bytes on an 8-bit bus Orgad Shaneh
2026-09-15  7:30 ` sashiko-bot
2026-09-15  7:50 ` [PATCH v2] mtd: cfi_cmdset_0002: cap the write-buffer chunk at 256 bytes on an x8 device Orgad Shaneh
2026-09-16 15:12   ` Miquel Raynal
2026-09-16 16:27     ` Orgad Shaneh
2026-09-17 12:46       ` Miquel Raynal [this message]
2026-09-16 16:27   ` [PATCH v3] " Orgad Shaneh
2026-09-25 14:28     ` Miquel Raynal
2026-10-06  5:24     ` [PATCH] mtd: cfi_cmdset_0002: also clamp the write buffer of an x16 part strapped to x8 Orgad Shaneh
2026-10-12 18:28       ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ecesjb9f.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=orgads@gmail.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.