From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCDB5C43458 for ; Mon, 13 Jul 2026 07:45:45 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1361496.1613717 (Exim 4.92) (envelope-from ) id 1wjBM4-0005Zf-NK; Mon, 13 Jul 2026 07:45:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1361496.1613717; Mon, 13 Jul 2026 07:45:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wjBM4-0005ZY-Jw; Mon, 13 Jul 2026 07:45:32 +0000 Received: by outflank-mailman (input) for mailman id 1361496; Mon, 13 Jul 2026 07:45:31 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wjBM2-0005ZS-Vd for xen-devel@lists.xenproject.org; Mon, 13 Jul 2026 07:45:30 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wjBM2-007GgG-2o for xen-devel@lists.xenproject.org; Mon, 13 Jul 2026 09:45:30 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a54978a-bab6-0a2a0a5309dd-0a2a4502863e-30 for ; Mon, 13 Jul 2026 09:45:29 +0200 Received: from [170.10.129.124] (helo=us-smtp-delivery-124.mimecast.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.2) (envelope-from ) id 6a549798-64c6-0a2a45020019-aa0a817cd613-3 for ; Mon, 13 Jul 2026 09:45:29 +0200 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-IZooiFzcPA6IroMRGoyIwg-1; Mon, 13 Jul 2026 03:45:24 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4EE9B18002C3; Mon, 13 Jul 2026 07:45:21 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.4]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1509E765; Mon, 13 Jul 2026 07:45:20 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A638D21E6920; Mon, 13 Jul 2026 09:45:17 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=mimecast20190719 header.d=redhat.com header.i="@redhat.com" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783928728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mKVnbI611gExUMjuzjUm1eZVIqPdwDXtnBh9poHdS4c=; b=OS6s4xl3cFcNsGf2w5FGUFhmRAGTUlk3zbHPcVR69Z1WNZFXYbbpP4dkqzEZG8SPVhGmEH FEAnqWrodniOl/417mu6arLDpvHfDPHo2xvBceZhxMHK3UXylV5bnTSwJfdqL/Mu6n0OxF hF1DaOpL4RV6836ABC6Lsd/nE2mZwic= X-MC-Unique: IZooiFzcPA6IroMRGoyIwg-1 X-Mimecast-MFC-AGG-ID: IZooiFzcPA6IroMRGoyIwg_1783928722 From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy Cc: jasowang@redhat.com, mst@redhat.com, peterx@redhat.com, farosas@suse.de, raphael.s.norwitz@gmail.com, bchaney@akamai.com, qemu-devel@nongnu.org, berrange@redhat.com, pbonzini@redhat.com, yc-core@yandex-team.ru, mark.caveayland@nutanix.com, Pierrick Bouvier , Sergio Lopez , Zhao Liu , Stefano Stabellini , Anthony PERARD , "Edgar E. Iglesias" , Bernhard Beschow , Alistair Francis , Palmer Dabbelt , Jason Wang , Eric Blake , devel@lists.libvirt.org (open list:Incompatible changes), xen-devel@lists.xenproject.org (open list:X86 Xen CPUs), qemu-ppc@nongnu.org (open list:e500), qemu-riscv@nongnu.org (open list:Microchip PolarFi...) Subject: Re: [PATCH v18 03/14] net/tap: deprecate "no" as special value for script/downscript In-Reply-To: <20260710191809.721154-4-vsementsov@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Fri, 10 Jul 2026 22:17:52 +0300") References: <20260710191809.721154-1-vsementsov@yandex-team.ru> <20260710191809.721154-4-vsementsov@yandex-team.ru> Date: Mon, 13 Jul 2026 09:45:17 +0200 Message-ID: <87ech7uycy.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-MFC-PROC-ID: SI_OOTtmjfjrBeyao0TsUdz0BdalIXkd-3rJ3EyrovM_1783928722 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-purgate-ID: tlsNG-720697/1783928729-3EF43A87-422508C4/0/0 X-purgate-type: clean X-purgate-size: 1451 Vladimir Sementsov-Ogievskiy writes: > The interface is ambiguous, as "no" is valid file name. So, > using "no" as a special value to disable script is deprecated. > Use an empty string ("script=" / "downscript=") instead. > > In a future version, "no" will be treated as a plain file name, just > like any other non-empty value. > > Document the deprecation in docs/about/deprecated.rst, qapi/net.json, > and qemu-options.hx. Update other docs to use empty string instead of > "no". Add a warning. > > Signed-off-by: Vladimir Sementsov-Ogievskiy [...] > diff --git a/net/tap.c b/net/tap.c > index fedd48c48d2..1ec9e5ebe6f 100644 > --- a/net/tap.c > +++ b/net/tap.c > @@ -103,6 +103,8 @@ static bool tap_is_explicit_no_script(const char *script_arg) > } > > if (strcmp(script_arg, "no") == 0) { > + warn_report("script=no/downscript=no is deprecated; " > + "use script=/downscript= instead"); net_init_tap() could pass the parameter name for a simpler error message. Probably not worth the bother. > return true; > } > In net_init_tap_one(): qemu_set_info_str(&s->nc, "ifname=%s,script=%s,downscript=%s", ifname, script ?: "no", downscript ?: "no"); This sets nc->info_str, which is shown by "info network". Should we replace "no" by ""? [...]