All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: ice1724: Fix blocking open for independent surround PCMs
Date: Tue, 19 May 2026 07:38:18 +0200	[thread overview]
Message-ID: <87ecj83qnp.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260518-ice1724-blocking-open-v1-1-1bfa3e5aa7cf@gmail.com>

On Mon, 18 May 2026 16:32:05 +0200,
Cássio Gabriel wrote:
> 
> The independent surround playback open path rejects a substream when the
> matching PDMA channel is reserved by the multi-channel PDMA0 stream. It
> currently returns -EBUSY for that case, although the driver has carried a
> FIXME noting that blocking mode is not handled properly.
> 
> ALSA PCM open waits and retries only when the low-level open callback
> returns -EAGAIN. Returning -EBUSY therefore makes blocking opens fail
> immediately, the same as nonblocking opens.
> 
> Return -EAGAIN for the temporary PDMA0 reservation conflict. The PCM core
> continues to report -EBUSY for O_NONBLOCK callers, while blocking callers
> sleep and retry.
> 
> Also wake the independent surround PCM wait queue when hw_free releases a
> PDMA reservation. The reservation can be released by the pro PCM, while
> waiters are sleeping on the independent surround PCM, so waking the current
> substream PCM is not sufficient for this cross-PCM reservation.
> 
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>

Applied to for-next branch now.  Thanks.


Takashi

      reply	other threads:[~2026-05-19  5:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 14:32 [PATCH] ALSA: ice1724: Fix blocking open for independent surround PCMs Cássio Gabriel
2026-05-19  5:38 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ecj83qnp.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=cassiogabrielcontato@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.