All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Zixun LI <admin@hifiphile.com>, Lukasz Majewski <lukma@denx.de>,
	Mattijs Korpershoek <mkorpershoek@kernel.org>
Cc: u-boot@lists.denx.de, stephan.gerhold@linaro.org
Subject: Re: Commit 59310d1ec (usb: gadget: introduce 'enabled' flag in struct usb_ep) broke atmel_usba_udc
Date: Wed, 13 May 2026 13:25:13 +0200	[thread overview]
Message-ID: <87ecjfv9eu.fsf@kernel.org> (raw)
In-Reply-To: <CA+GyqeZ8=P_i98Y4wT0Hfi9cmfvKsHn-upQ2h51zGB54-_JZvQ@mail.gmail.com>

Hi Zixun,

On Tue, May 12, 2026 at 12:23, Zixun LI <admin@hifiphile.com> wrote:

> Hi,
> With 59310d1ec an "enabled" flag has been introduced to guard ep->ops
> against
> disable before enable or vice versa.
> In atmel_usba_udc/usba_ep_disable() returns an error if the endpoint is
> already disabled.
> When the gadget is re-attached, for example a dhcp command triggers
> usb_gadget_ops.pullup event, the bus is reset and
> atmel_usba_udc/reset_all_endpoints() is called. Since ep->enabled flag is
> still
> true, following usb_ep_disable()/usb_ep_enable() calls will fail.
>
> What's the correct fix, change atmel_usba_udc/reset_all_endpoints() ?

Thank you for testing and reporting this problem.
I've seen you have posted a patch fixing this here:
https://lore.kernel.org/all/20260512-udc_ep-v1-1-8a783e44cf7f@hifiphile.com/

Let's continue the discussion there.

Regards
Mattijs

>
> Regards,
> Zixun

      reply	other threads:[~2026-05-13 11:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 10:23 Commit 59310d1ec (usb: gadget: introduce 'enabled' flag in struct usb_ep) broke atmel_usba_udc Zixun LI
2026-05-13 11:25 ` Mattijs Korpershoek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ecjfv9eu.fsf@kernel.org \
    --to=mkorpershoek@kernel.org \
    --cc=admin@hifiphile.com \
    --cc=lukma@denx.de \
    --cc=stephan.gerhold@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.