From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AFE8108E1E9 for ; Thu, 19 Mar 2026 11:21:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3BQS-0007mw-Va; Thu, 19 Mar 2026 07:20:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3BQP-0007kx-Q9 for qemu-trivial@nongnu.org; Thu, 19 Mar 2026 07:20:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3BQN-0005oQ-KW for qemu-trivial@nongnu.org; Thu, 19 Mar 2026 07:20:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773919222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z3LCxgyFo0bzjru08OdGjin0hQE9Ce/IR6a1VQcoVHc=; b=RERKRciSC7LOqjJKre0mlV66wvP16Ivhr8y3q+GBHVneKPOY2VkYZ6jvEoUdyG87WZYyn9 EXIlwP42Oubvz9nhYCJ/uGUeTKlw/ONtVSXxLA1h3WMsP+oXX9IBVYT8e9i5OIp2sLT+3p wBW9rsNjOixYzRizz5J8rExw7AFGwNE= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-399-dYbhEiGgMHyE3jHtWZoM_w-1; Thu, 19 Mar 2026 07:20:18 -0400 X-MC-Unique: dYbhEiGgMHyE3jHtWZoM_w-1 X-Mimecast-MFC-AGG-ID: dYbhEiGgMHyE3jHtWZoM_w_1773919217 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 763E41800371; Thu, 19 Mar 2026 11:20:16 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8B2051955F21; Thu, 19 Mar 2026 11:20:15 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E871321E6937; Thu, 19 Mar 2026 12:20:12 +0100 (CET) From: Markus Armbruster To: Thomas Huth Cc: =?utf-8?Q?Herv=C3=A9?= Poussineau , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, qemu-trivial@nongnu.org, BALATON Zoltan Subject: Re: [PATCH] hw/pci-host/raven: Fix crash when introspecting raven-pcihost from the CLI In-Reply-To: <20260317074049.436460-1-thuth@redhat.com> (Thomas Huth's message of "Tue, 17 Mar 2026 08:40:49 +0100") References: <20260317074049.436460-1-thuth@redhat.com> Date: Thu, 19 Mar 2026 12:20:12 +0100 Message-ID: <87eclgawwj.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-MFC-PROC-ID: a1d70h29KFyTses5N5KQ7AN_awgD9BqDF2XFanHzyUg_1773919217 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org Sender: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org Thomas Huth writes: > From: Thomas Huth > > QEMU currently crashes when introspecting raven-pcihost from the command > line interface: > > $ ./qemu-system-ppc -device raven-pcihost,help > Segmentation fault (core dumped) > > This happens because the raven_pcihost_initfn instance init function > calls get_system_memory(), but that is not available here yet. > > There does not seem to be a compelling reason for initializing the > memory regions from the instance init function, so let's simply move > the code into the realize() function instead to fix this issue. > > Signed-off-by: Thomas Huth Tested-by: Markus Armbruster