All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Igor Mammedov" <imammedo@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org, mst@redhat.com, anisinha@redhat.com,
	pbonzini@redhat.com, shannon.zhaosl@gmail.com, philmd@linaro.org,
	zhao1.liu@intel.com, rad@semihalf.com,
	leif.lindholm@oss.qualcomm.com
Subject: Re: [PATCH 08/11] arm: virt: create GWDT watchdog paired with WDAT ACPI table
Date: Mon, 02 Mar 2026 06:32:30 +0100	[thread overview]
Message-ID: <87ecm26bkh.fsf@pond.sub.org> (raw)
In-Reply-To: <CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com> (Peter Maydell's message of "Fri, 27 Feb 2026 15:01:28 +0000")

Peter Maydell <peter.maydell@linaro.org> writes:

> On Fri, 27 Feb 2026 at 14:51, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Peter Maydell <peter.maydell@linaro.org> writes:
>>
>> > On Fri, 27 Feb 2026 at 12:10, Markus Armbruster <armbru@redhat.com> wrote:
>> >> The larger problem is that we generally fail at documenting device and
>> >> machine properties.  I'm not asking you to boil that ocean :)
>> >>
>> >> The narrow problem is providing guidance on watchdog configuration.
>> >> What and where?
>> >>
>> >> Regarding where: you proposed to add a machine property of QAPI enum
>> >> type.
>> >>
>> >> The property can have a description, and you give it one.  Sadly, it's
>> >> basically invisible.  As far as I know, the only way you can get at it
>> >> is qom-list-properties and such.  I doubt anybody is going to read the
>> >> description there.
>> >
>> > I think it also will appear if you run e.g.
>> >  qemu-system-arm -M virt,help
>> >
>> > (which produces a list of all properties with their short descriptions)
>>
>> You're right!
>>
>> > For board-specific properties, we should be documenting these in
>> > the manual page for the board. For instance "virt" does that here:
>> >  https://www.qemu.org/docs/master/system/arm/virt.html#machine-specific-options
>>
>> Every board should have such a page.  Even if it's just a placeholder.
>> Placeholders would remind us where the gaps are.
>
> I agree. For Arm I believe every board should already have a docs page,
> even if a very minimal one. (Some closely related boards get
> described on a single page that covers that whole family of boards.)
> The full list of pages is here:
>  https://www.qemu.org/docs/master/system/target-arm.html
>
> We follow the same pattern (but not always with complete coverage)
> in most but not all the other target architectures.
>
> I don't think there's currently any automatic way to get a list
> of undocumented boards, because there isn't any tagging of the
> boards that are documented except in as much as the board names
> are listed in the title of the relevant pages.

Alright, here's a first and incomplete attempt at the manual way.

docs/system/targets.rst "QEMU System Emulator Targets" lists target
pages docs/system/target-ARCH:

    target-arm
    target-avr
    target-loongarch
    target-m68k
    target-mips
    target-or1k
    target-ppc
    target-riscv
    target-rx
    target-s390x
    target-sparc
    target-sparc64
    target-i386
    target-xtensa

These appear to be mostly per "arch", not per target, i.e. there's just
target-mips, not -mips, -mipsel, -mips64, mips64el.  Exception: -sparc
and -sparc64.

Checking against include/system/arch_init.h...  We're missing

    target-alpha
    target-hexagon
    target-hppa
    target-microblaze
    target-sh4
    target-tricore

Some target pages list board pages under a "Board-specific
documentation" heading:

    target-arm
        arm/max78000
        arm/integratorcp
        arm/mps2
        arm/musca
        arm/realview
        arm/sbsa
        arm/versatile
        arm/vexpress
        arm/aspeed
        arm/bananapi_m2u.rst
        arm/b-l475e-iot01a.rst
        arm/sabrelite
        arm/highbank
        arm/digic
        arm/cubieboard
        arm/emcraft-sf2
        arm/exynos
        arm/fby35
        arm/musicpal
        arm/kzm
        arm/nrf
        arm/nuvoton
        arm/imx25-pdk
        arm/mcimx6ul-evk
        arm/mcimx7d-sabre
        arm/imx8mp-evk
        arm/orangepi
        arm/raspi
        arm/collie
        arm/sx1
        arm/stellaris
        arm/stm32
        arm/virt
        arm/vmapple
        arm/xenpvh
        arm/xlnx-versal-virt
        arm/xlnx-zynq
        arm/xlnx-zcu102
    target-i386
        i386/pc
        i386/microvm
        i386/nitro-enclave
    target-loongarch
        loongarch/virt
    target-or1k
        or1k/or1k-sim
        or1k/virt
    target-ppc
        ppc/amigang
        ppc/embedded
        ppc/powermac
        ppc/powernv
        ppc/ppce500
        ppc/prep
        ppc/pseries
    target-riscv
        riscv/microblaze-v-generic
        riscv/microchip-icicle-kit
        riscv/mips
        riscv/shakti-c
        riscv/sifive_u
        riscv/virt
        riscv/xiangshan-kunminghu

Pages may cover multiple machine types (e.g. ppc/amigang covers
amigaone, pegasos1, pegasos2, sam460ex).  We might want to tweak titles
to help us find the board names more easily, so we can check for
completeness.

Target pages without a "Board-specific documentation" heading:

    target-avr
    target-m68k
    target-mips
    target-rx
    target-s390x
    target-sparc
    target-sparc64
    target-xtensa

Some of these do talk about boards, just in less greppable ways.  We
might want to adjust them to better support completeness checking.

Worth pursuing this further?



  reply	other threads:[~2026-03-02  5:33 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-06 13:14 [PATCH 00/11] Introduce ACPI watchdog for Q35 and arm/virt boards Igor Mammedov
2026-02-06 13:14 ` [PATCH 01/11] acpi: add API to build WDAT instructions Igor Mammedov
2026-02-16  8:12   ` Ani Sinha
2026-02-06 13:14 ` [PATCH 02/11] machine: add "acpi-watchdog" property Igor Mammedov
2026-02-16  8:23   ` Ani Sinha
2026-02-26 17:08   ` Philippe Mathieu-Daudé
2026-02-27  8:23     ` Igor Mammedov
2026-02-06 13:14 ` [PATCH 03/11] x86: q35: generate WDAT ACPI table Igor Mammedov
2026-02-16 10:51   ` Ani Sinha
2026-02-06 13:14 ` [PATCH 04/11] tests: acpi: x86/q35: whitelist new WDAT table Igor Mammedov
2026-02-16  9:50   ` Ani Sinha
2026-02-06 13:14 ` [PATCH 05/11] tests: acpi: x86/q35: add WDAT table test case Igor Mammedov
2026-02-16  9:51   ` Ani Sinha
2026-02-06 13:14 ` [PATCH 06/11] tests: acpi: x86/q35: update expected WDAT blob Igor Mammedov
2026-02-17  5:34   ` Ani Sinha
2026-02-06 13:14 ` [PATCH 07/11] arm: add tracing events to sbsa_gwdt Igor Mammedov
2026-02-16 10:22   ` Ani Sinha
2026-02-06 13:14 ` [PATCH 08/11] arm: virt: create GWDT watchdog paired with WDAT ACPI table Igor Mammedov
2026-02-18 19:08   ` Peter Maydell
2026-02-19 12:17     ` Igor Mammedov
2026-02-19 13:00       ` Peter Maydell
2026-02-19 14:55         ` Igor Mammedov
2026-02-19 16:04           ` Peter Maydell
2026-02-23  9:28             ` Igor Mammedov
2026-02-25 15:11             ` Daniel P. Berrangé
2026-02-25 15:19       ` Daniel P. Berrangé
2026-02-26 12:56         ` Igor Mammedov
2026-02-27  7:24           ` Markus Armbruster
2026-02-27  9:01             ` Daniel P. Berrangé
2026-02-27 10:01               ` Igor Mammedov
2026-02-27 10:18                 ` Daniel P. Berrangé
2026-02-27 11:41                   ` Igor Mammedov
2026-02-27  9:42             ` Igor Mammedov
2026-02-27 12:10               ` Markus Armbruster
2026-02-27 13:14                 ` Peter Maydell
2026-02-27 14:51                   ` Markus Armbruster
2026-02-27 15:01                     ` Peter Maydell
2026-03-02  5:32                       ` Markus Armbruster [this message]
2026-02-06 13:14 ` [PATCH 09/11] tests: acpi: arm/virt: whitelist new WDAT table Igor Mammedov
2026-02-06 13:14 ` [PATCH 10/11] tests: acpi: arm/virt: add WDAT table test case Igor Mammedov
2026-02-06 13:14 ` [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob Igor Mammedov
2026-02-16  7:39 ` [PATCH 00/11] Introduce ACPI watchdog for Q35 and arm/virt boards Ani Sinha
2026-02-16  8:46   ` Mohamed Mediouni
2026-02-18  9:29   ` Igor Mammedov
2026-02-18 19:10 ` Peter Maydell
2026-02-19 12:27   ` Igor Mammedov
2026-02-19 14:05     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ecm26bkh.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=anisinha@redhat.com \
    --cc=berrange@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=leif.lindholm@oss.qualcomm.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rad@semihalf.com \
    --cc=shannon.zhaosl@gmail.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.