From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18C0E1C7012 for ; Sat, 28 Feb 2026 08:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772267313; cv=none; b=dedzQ6IJCjZ24z2ia4fY3rpuK+Vuaw9xan/7Ji8VUVMlm8f59oYe7p3r1T/XmJaS6TKajSE+LzRBBcNiW1tt+fNsXL7XIMSo8sut11hd6VCXvx9FXWjWhRDndi2n0UDfRhr78RwpW7vPBT5rImh9fvp4W2WIj1wnjfAJoEk9BEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772267313; c=relaxed/simple; bh=IO0NuQkZq1v9AOwQZTvRIArwiDPeW7eMEUHT3ICml3U=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=KaSJgVlXWRvxu9LhxcpYcS0uUBClssB74GB1vpBxzsCE1wRd+pKwAa3ZOgpHKH63utVv9nGsPNWtgwCfcTs69SHRVc5u7Bh0abtXGcoLu8OVmt8mrA5xHRaQs6IZcOT7jcrUacB2XSMK6qI2uacqP28vnvosFx32GNWxNVQR8sU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=z5wOverZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=R2JhLDMt; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=z5wOverZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=R2JhLDMt; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="z5wOverZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="R2JhLDMt"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="z5wOverZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="R2JhLDMt" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 65E555BCF4; Sat, 28 Feb 2026 08:28:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772267310; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mojBVRrhReVO1AGNefbxawIW3tbCAEk1HHjbG0Nk/pg=; b=z5wOverZdG0kTC4GJXbLWMXhIyQhuVNzEohTm1H1/MKRRlt9u1NyXNefVgMQfYHpkh2Lsf EniYaF95ZLP1o/1SCDEPGvngrW4dtG8qpWUcot5O0HFOmYa/4s8e1QZji7HmJSNSaruXas 6rhsjAPKbXWNCBgzREP0iw6My3KDmS0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772267310; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mojBVRrhReVO1AGNefbxawIW3tbCAEk1HHjbG0Nk/pg=; b=R2JhLDMtNMTNRmX+v9ij/nuNerjS5jvndNgByJhQkZZSiC7KddlXVohu7Abs19RC6lzGG1 gKEwnpxuKE/ET0Bg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772267310; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mojBVRrhReVO1AGNefbxawIW3tbCAEk1HHjbG0Nk/pg=; b=z5wOverZdG0kTC4GJXbLWMXhIyQhuVNzEohTm1H1/MKRRlt9u1NyXNefVgMQfYHpkh2Lsf EniYaF95ZLP1o/1SCDEPGvngrW4dtG8qpWUcot5O0HFOmYa/4s8e1QZji7HmJSNSaruXas 6rhsjAPKbXWNCBgzREP0iw6My3KDmS0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772267310; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mojBVRrhReVO1AGNefbxawIW3tbCAEk1HHjbG0Nk/pg=; b=R2JhLDMtNMTNRmX+v9ij/nuNerjS5jvndNgByJhQkZZSiC7KddlXVohu7Abs19RC6lzGG1 gKEwnpxuKE/ET0Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1377B3EA65; Sat, 28 Feb 2026 08:28:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vxBdAy6nommgRwAAD6G6ig (envelope-from ); Sat, 28 Feb 2026 08:28:30 +0000 Date: Sat, 28 Feb 2026 09:28:29 +0100 Message-ID: <87ecm56zma.wl-tiwai@suse.de> From: Takashi Iwai To: Shenghao Ding Cc: , , , , , , <13564923607@139.com>, <13916275206@139.com>, , Subject: Re: [PATCH v1] ALSA: hda/tas2781: A workaround solution to lower-vol issue among lower calibrated-impedance micro-speaker on TAS2781 In-Reply-To: <20260227144641.1243-1-shenghao-ding@ti.com> References: <20260227144641.1243-1-shenghao-ding@ti.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -3.29 X-Spam-Level: X-Spamd-Result: default: False [-3.29 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_SHORT(-0.19)[-0.964]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_SEVEN(0.00)[11]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[139.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; URIBL_BLOCKED(0.00)[ti.com:email,imap1.dmz-prg2.suse.org:helo,suse.de:mid]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[suse.de,kernel.org,linux.intel.com,vger.kernel.org,ti.com,fpt.com,139.com,linux.dev,antheas.dev]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid] X-Spam-Flag: NO On Fri, 27 Feb 2026 15:46:40 +0100, Shenghao Ding wrote: > > On TAS2781, if the Speaker calibrated impedance is lower than default > value hard-coded inside the TAS2781, it will cuase vol lower than > normal. In order to fix this issue, the parameter of SineGainI need > updating. > > Signed-off-by: Shenghao Ding > > --- > v1: > - Add tas2781_cali_preproc() to check whether the calibrated-impedance is lower than the default value. If so, update the SineGainI. > - Specify the TAS2781 chipid for cliabrated data preprocessing. > - Revert b7e26c8bdae7 ("ALSA: hda/tas2781: Skip UEFI calibration on ASUS ROG Xbox Ally X") in tas2781. Thanks, applied now. Takashi