All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
	jasowang@redhat.com,  mst@redhat.com,  pbonzini@redhat.com,
	berrange@redhat.com,  thuth@redhat.com,  armbru@redhat.com,
	eblake@redhat.com,  farosas@suse.de,  zhao1.liu@intel.com,
	wangyanan55@huawei.com,  philmd@linaro.org,
	 marcel.apfelbaum@gmail.com, eduardo@habkost.net,
	 davydov-max@yandex-team.ru,  qemu-devel@nongnu.org,
	yc-core@yandex-team.ru,  leiyang@redhat.com,
	raphael.s.norwitz@gmail.com,  bchaney@akamai.com
Subject: Re: [PATCH v10 3/8] qapi: add backend-transfer migration parameter
Date: Thu, 05 Feb 2026 08:07:34 +0100	[thread overview]
Message-ID: <87ecmzu0qx.fsf@pond.sub.org> (raw)
In-Reply-To: <aYOAAfzZQ3PeKf4q@x1.local> (Peter Xu's message of "Wed, 4 Feb 2026 12:21:05 -0500")

Peter Xu <peterx@redhat.com> writes:

> On Sun, Feb 01, 2026 at 07:19:55PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>>  # @migrate-set-parameters:
>> @@ -1004,6 +1005,13 @@
>>  #     is @cpr-exec.  The first list element is the program's filename,
>>  #     the remainder its arguments.  (Since 10.2)
>>  #
>> +# @backend-transfer: Enable backend-transfer feature for devices that
>> +#     supports it.  In general that means that backend state and its
>> +#     file descriptors are passed to the destination in the migraton
>> +#     channel (which must be a UNIX socket).  Individual devices
>> +#     declare the support for backend-transfer by per-device
>> +#     backend-transfer option.  (Since 11.0)
>
> I still think it'll be nice to either have "local" in the name of parameter
> or at least document it with crystal clear terms.
>
> I used to suggest fd-passing, but maybe you wanted to emphasize there's
> more than fds to be migrated at least for tap? Then it can still be
> "local-backend-transfer", because nobody stops a device to transfer backend
> states in a remote migration either.. so "backend-transfer" seems to also
> work for remote migrations, but it is not.
>
> Or at least mentioned explicitly in the comment, saying this is a local
> migration / upgrade.

Documenting the restriction is a must regardless of naming.  The
proposed text does document it, but only indirectly: "(which must be a
UNIX socket)".  Could be improved, I guess.

Capturing the restriction in the name might help.  But it also makes the
name longer.  Feels like a matter of taste to me.  You guys decide :)

> If you could at least update the doc on the locality attribute for the
> migration (one way or another..), feel free to take:
>
> Acked-by: Peter Xu <peterx@redhat.com>
>
> If you decide to rename, that's even better.
>
> Thanks,



  reply	other threads:[~2026-02-05  7:08 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-01 16:19 [PATCH v10 0/8] virtio-net: live-TAP local migration Vladimir Sementsov-Ogievskiy
2026-02-01 16:19 ` [PATCH v10 1/8] net/tap: move vhost-net open() calls to tap_parse_vhost_fds() Vladimir Sementsov-Ogievskiy
2026-02-01 16:19 ` [PATCH v10 2/8] net/tap: move vhost initialization to tap_setup_vhost() Vladimir Sementsov-Ogievskiy
2026-02-01 16:19 ` [PATCH v10 3/8] qapi: add backend-transfer migration parameter Vladimir Sementsov-Ogievskiy
2026-02-04 13:08   ` Markus Armbruster
2026-02-04 17:21   ` Peter Xu
2026-02-05  7:07     ` Markus Armbruster [this message]
2026-02-05  8:06       ` Vladimir Sementsov-Ogievskiy
2026-02-05 16:25         ` Peter Xu
2026-02-06  8:56           ` Vladimir Sementsov-Ogievskiy
2026-02-06 16:08             ` Peter Xu
2026-02-06 20:37               ` Vladimir Sementsov-Ogievskiy
2026-02-01 16:19 ` [PATCH v10 4/8] net: introduce vmstate_net_peer_backend Vladimir Sementsov-Ogievskiy
2026-02-01 16:19 ` [PATCH v10 5/8] virtio-net: support backend-transfer migration Vladimir Sementsov-Ogievskiy
2026-02-01 16:19 ` [PATCH v10 6/8] net/tap: " Vladimir Sementsov-Ogievskiy
2026-02-04 16:46   ` Chaney, Ben
2026-02-05  8:12     ` Vladimir Sementsov-Ogievskiy
2026-02-05 14:51       ` Chaney, Ben
2026-02-06  9:00         ` Vladimir Sementsov-Ogievskiy
2026-02-01 16:19 ` [PATCH v10 7/8] tests/functional: add skipWithoutSudo() decorator Vladimir Sementsov-Ogievskiy
2026-02-01 16:20 ` [PATCH v10 8/8] tests/functional: add test_tap_migration Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ecmzu0qx.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=bchaney@akamai.com \
    --cc=berrange@redhat.com \
    --cc=davydov-max@yandex-team.ru \
    --cc=eblake@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=farosas@suse.de \
    --cc=jasowang@redhat.com \
    --cc=leiyang@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=raphael.s.norwitz@gmail.com \
    --cc=thuth@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    --cc=wangyanan55@huawei.com \
    --cc=yc-core@yandex-team.ru \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.