From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Chris Morgan <macroalpha82@gmail.com>, u-boot@lists.denx.de
Cc: thinhn@synopsys.com, neil.armstrong@linaro.org,
quic_varada@quicinc.com, felipe.balbi@linux.intel.com,
mkorpershoek@kernel.org, lukma@denx.de, trini@konsulko.com,
marex@denx.de, macromorgan@hotmail.com
Subject: Re: [PATCH V2 3/4] usb: dwc3: gadget: Don't send unintended link state change
Date: Thu, 29 Jan 2026 10:06:39 +0100 [thread overview]
Message-ID: <87ecn8okio.fsf@kernel.org> (raw)
In-Reply-To: <20260115230135.183158-4-macroalpha82@gmail.com>
Hi Chris,
Thank you for the patch.
On Thu, Jan 15, 2026 at 17:01, Chris Morgan <macroalpha82@gmail.com> wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> DCTL.ULSTCHNGREQ is a write-only field. When doing a read-modify-write
> to DCTL, the driver must make sure that there's no unintended link state
> change request from whatever is read from DCTL.ULSTCHNGREQ. Set link
> state change to no-action when the driver writes to DCTL.
>
> Note that this patch was submitted upstream in Linux in 2020 [1],
> and I've confirmed I need it in U-Boot to enable gadget mode.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/patch/drivers/usb/dwc3?id=5b738211fb59e114727381d07c647a77c0010996
>
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
> ---
> drivers/usb/dwc3/gadget.c | 16 +++++++---------
> drivers/usb/dwc3/gadget.h | 14 ++++++++++++++
> 2 files changed, 21 insertions(+), 9 deletions(-)
>
next prev parent reply other threads:[~2026-01-29 9:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 23:01 [PATCH V2 0/4] USB Fixes for Gadget Mode on DWC3 Chris Morgan
2026-01-15 23:01 ` [PATCH V2 1/4] usb: dwc3: core: Add ip and version_type support from Linux Chris Morgan
2026-01-29 8:49 ` Mattijs Korpershoek
2026-01-15 23:01 ` [PATCH V2 2/4] usb: dwc3: Increase DWC3 controller halt timeout Chris Morgan
2026-01-29 8:51 ` Mattijs Korpershoek
2026-01-15 23:01 ` [PATCH V2 3/4] usb: dwc3: gadget: Don't send unintended link state change Chris Morgan
2026-01-29 9:06 ` Mattijs Korpershoek [this message]
2026-01-15 23:01 ` [PATCH V2 4/4] usb: dwc3: core: improve reset sequence Chris Morgan
2026-01-22 12:15 ` Ernest Van Hoecke
2026-01-22 12:34 ` Marek Vasut
2026-01-23 7:24 ` 回复: " Alice Guo (OSS)
2026-01-23 14:12 ` Ernest Van Hoecke
2026-01-27 1:58 ` 回复: " Alice Guo (OSS)
2026-02-05 17:32 ` Ernest Van Hoecke
2026-02-25 11:04 ` 回复: " Alice Guo (OSS)
2026-01-29 9:38 ` Mattijs Korpershoek
2026-01-30 8:00 ` [PATCH V2 0/4] USB Fixes for Gadget Mode on DWC3 Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecn8okio.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=lukma@denx.de \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=marex@denx.de \
--cc=neil.armstrong@linaro.org \
--cc=quic_varada@quicinc.com \
--cc=thinhn@synopsys.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.