From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77045D4899D for ; Fri, 16 Jan 2026 13:21:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vgjlE-0001wl-MJ; Fri, 16 Jan 2026 08:21:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgjlC-0001vh-RS for qemu-devel@nongnu.org; Fri, 16 Jan 2026 08:21:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgjlB-0005OM-Hi for qemu-devel@nongnu.org; Fri, 16 Jan 2026 08:21:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768569664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mBCyE4ya3KDVjy2Y+vtTClxqoD//HhvWikCh8pjVd4c=; b=HYvlneNcS6SKaOghBCRtI9nS4iFfI8HCt61Gkv5fraAU9Vb0ZZd4Ju/SCKvZkOE4RenzA3 y/sR1By/CReGf52qQapfrMOv8JvZ50sIbD+8sb4LS4cy5SIMa6HsLuLSLTLlNPkTJdFRSx BqGhWeK8bdEDGpAyw3zEIZHCvc071aA= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-318-gCgjx2ymMIisSy6zOfuoEQ-1; Fri, 16 Jan 2026 08:21:02 -0500 X-MC-Unique: gCgjx2ymMIisSy6zOfuoEQ-1 X-Mimecast-MFC-AGG-ID: gCgjx2ymMIisSy6zOfuoEQ_1768569661 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 12BB2180034A; Fri, 16 Jan 2026 13:21:01 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.32]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 45222180009E; Fri, 16 Jan 2026 13:21:00 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E740B21E692D; Fri, 16 Jan 2026 14:20:57 +0100 (CET) From: Markus Armbruster To: Peter Maydell Cc: qemu-devel@nongnu.org, Magnus Kulke , Wei Liu , Warner Losh , Kyle Evans , Richard Henderson , Helge Deller , Michael Roth , Kostiantyn Kostiuk , Marcelo Tosatti Subject: Re: [PATCH 3/4] misc: Clean up includes In-Reply-To: <20260116125830.926296-4-peter.maydell@linaro.org> (Peter Maydell's message of "Fri, 16 Jan 2026 12:58:29 +0000") References: <20260116125830.926296-1-peter.maydell@linaro.org> <20260116125830.926296-4-peter.maydell@linaro.org> Date: Fri, 16 Jan 2026 14:20:57 +0100 Message-ID: <87ecnpwv5y.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Maydell writes: > This commit deals with various .c files that included system > headers that are already pulled in by osdep.h, where the .c > file includes osdep.h already itself. > > This commit was created with scripts/clean-includes: > ./scripts/clean-includes '--git' 'misc' 'hw/core' 'semihosting' 'target/arm' 'target/i386/kvm/kvm.c' 'target/loongarch' 'target/riscv' 'tools' 'util' > > All .c should include qemu/osdep.h first. The script performs three > related cleanups: > > * Ensure .c files include qemu/osdep.h first. > * Including it in a .h is redundant, since the .c already includes > it. Drop such inclusions. > * Likewise, including headers qemu/osdep.h includes is redundant. > Drop these, too. > > Signed-off-by: Peter Maydell Reviewed-by: Markus Armbruster