From: Takashi Iwai <tiwai@suse.de>
To: fenugrec@mail.com
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
roy.vegard.ovesen@gmail.com, mickflemm@gmail.com
Subject: Re: [PATCH v2 0/2] ALSA: usb-audio: presonus s1810 minor cleanup and document
Date: Tue, 13 Jan 2026 13:22:18 +0100 [thread overview]
Message-ID: <87ecntr9c5.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260111-preso_clean1-v2-0-44b4e5129a75@mail.com>
On Sun, 11 Jan 2026 22:36:39 +0100,
fenugrec via B4 Relay wrote:
>
> patch v2 : apologies, I had missed an __le32 field.
>
> - Use __le32 fields for structures sent/received over USB
> Addresses a comment from when this driver was initially merged:
> https://lore.kernel.org/all/s5hd0agcjw1.wl-tiwai@suse.de/
>
> - Document constants and protocol details common to the Studio 1810 and
> 1824c devices
>
> Except for a hypothetical big-endian platform (which I cannot test) where the first
> commit would make a difference, both these should have no functional
> change.
>
> Signed-off-by: fenugrec <fenugrec@mail.com>
> ---
> Changes in v2:
> - fix an overlooked __le32 conversion for .tag and .len fields
> - Link to v1: https://lore.kernel.org/r/20260110-preso_clean1-v1-0-ce2dd3ea4506@mail.com
Thanks for the patches. The code changes look OK, so I can take as
is.
But I wonder about your identity "fenugrec". Is it a real name?
The Signed-off-by line needs to be a real name (or a known identity)
for legal reasons.
thanks,
Takashi
next prev parent reply other threads:[~2026-01-13 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 21:36 [PATCH v2 0/2] ALSA: usb-audio: presonus s1810 minor cleanup and document fenugrec
2026-01-11 21:36 ` fenugrec via B4 Relay
2026-01-11 21:36 ` [PATCH v2 1/2] ALSA: usb-audio: presonus s18xx uses little-endian fenugrec
2026-01-11 21:36 ` fenugrec via B4 Relay
2026-01-11 21:36 ` [PATCH v2 2/2] ALSA: usb-audio: clean up presonus s1810 consts fenugrec
2026-01-11 21:36 ` fenugrec via B4 Relay
2026-01-13 12:22 ` Takashi Iwai [this message]
2026-01-13 14:10 ` [PATCH v2 0/2] ALSA: usb-audio: presonus s1810 minor cleanup and document fenugrec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecntr9c5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=fenugrec@mail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mickflemm@gmail.com \
--cc=roy.vegard.ovesen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.