From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: Fix stray and typo "pinctrl-names" properties
Date: Wed, 07 Jan 2026 17:49:16 +0100 [thread overview]
Message-ID: <87eco1qsfn.fsf@BLaptop.bootlin.com> (raw)
In-Reply-To: <20260105194642.3189113-1-robh@kernel.org>
"Rob Herring (Arm)" <robh@kernel.org> writes:
> There's several cases of "pinctrl-names" used without any "pinctrl-0"
> properties. Drop them.
>
> Fix the typo "pintrl-names" as well.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Applied on mvebu/dt64
Thanks,
Gregory
> ---
> arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 1 -
> arch/arm64/boot/dts/marvell/cn9130-cf-base.dts | 2 +-
> arch/arm64/boot/dts/marvell/cn9130-crb.dtsi | 1 -
> arch/arm64/boot/dts/marvell/cn9130-db.dtsi | 2 --
> arch/arm64/boot/dts/marvell/cn9132-db.dtsi | 1 -
> 5 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> index e82284888b9a..0ab33aa928e7 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> @@ -42,7 +42,6 @@ usb3_phy: usb3-phy {
> };
>
> gpio-leds {
> - pinctrl-names = "default";
> compatible = "gpio-leds";
> /* No assigned functions to the LEDs by default */
> led1 {
> diff --git a/arch/arm64/boot/dts/marvell/cn9130-cf-base.dts b/arch/arm64/boot/dts/marvell/cn9130-cf-base.dts
> index 788a5c302b17..212865f6cf6a 100644
> --- a/arch/arm64/boot/dts/marvell/cn9130-cf-base.dts
> +++ b/arch/arm64/boot/dts/marvell/cn9130-cf-base.dts
> @@ -137,7 +137,7 @@ led@1 {
>
> &cp0_pinctrl {
> pinctrl-0 = <&sim_select_pins>;
> - pintrl-names = "default";
> + pinctrl-names = "default";
>
> rear_button_pins: cp0-rear-button-pins {
> marvell,pins = "mpp31";
> diff --git a/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi b/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
> index 5689a8bdfd03..c9050e707a60 100644
> --- a/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
> +++ b/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
> @@ -93,7 +93,6 @@ &uart0 {
>
> /* on-board eMMC U6 */
> &ap_sdhci0 {
> - pinctrl-names = "default";
> bus-width = <8>;
> status = "okay";
> mmc-ddr-1_8v;
> diff --git a/arch/arm64/boot/dts/marvell/cn9130-db.dtsi b/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
> index 7156739aa31a..8e413286e019 100644
> --- a/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
> +++ b/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
> @@ -111,7 +111,6 @@ &uart0 {
>
> /* on-board eMMC - U9 */
> &ap_sdhci0 {
> - pinctrl-names = "default";
> bus-width = <8>;
> vqmmc-supply = <&ap0_reg_sd_vccq>;
> status = "okay";
> @@ -166,7 +165,6 @@ &cp0_i2c0 {
> /* U36 */
> expander0: pca953x@21 {
> compatible = "nxp,pca9555";
> - pinctrl-names = "default";
> gpio-controller;
> #gpio-cells = <2>;
> reg = <0x21>;
> diff --git a/arch/arm64/boot/dts/marvell/cn9132-db.dtsi b/arch/arm64/boot/dts/marvell/cn9132-db.dtsi
> index f82d45e62753..98eee9e4e10b 100644
> --- a/arch/arm64/boot/dts/marvell/cn9132-db.dtsi
> +++ b/arch/arm64/boot/dts/marvell/cn9132-db.dtsi
> @@ -142,7 +142,6 @@ i2c@1 {
> /* U12 */
> cp2_module_expander1: pca9555@21 {
> compatible = "nxp,pca9555";
> - pinctrl-names = "default";
> gpio-controller;
> #gpio-cells = <2>;
> reg = <0x21>;
> --
> 2.51.0
>
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-01-07 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 19:46 [PATCH] arm64: dts: marvell: Fix stray and typo "pinctrl-names" properties Rob Herring (Arm)
2026-01-07 16:49 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eco1qsfn.fsf@BLaptop.bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.