From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6204FC54FB3 for ; Mon, 26 May 2025 08:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MgtOER3U4gxU8fyBx6xGXFGaVy0FwJBZ3S5BXefFoPs=; b=AhWG+CqlK/eh/u 0lDYBY4KpMyubczbAvTWh+cJC5qJiTXNoJ0uDimKnWW35djvfcKlIaLByoI+sVFPLygHklHCoBwVw zDuE3RmbJqmNvhWrm8A0JqTRcA8ERooG+5GMFd81iSgYKSrNgA5QP9jiV7XpcHqEr308doeP+ACy7 CKaGiSd6lhj0yQvEwoz5515ut/3nhhPEmfUdn1lpZL8U7lcshvCcq8pwBIANN8TohEq3n9j+me/OZ TOyktU7/VfRSy77yCTgfQ5yrdkh/mRm+aqqcmFR3dPp5U0zDr3p+nHIMRscYClznx26qT1bDNG79B uOoGgc6T/7/MDoQOjBTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uJSw7-00000008Lr2-0wtD; Mon, 26 May 2025 08:11:55 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uJSuw-00000008LiO-2no8 for linux-mtd@lists.infradead.org; Mon, 26 May 2025 08:10:44 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 09B0F432A2; Mon, 26 May 2025 08:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1748247040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GuNkJwVVyWMP6VzsZqlzIYpsiMS21Kc27Fn5oFSy5nU=; b=V392rnYF+b8ejLtIgotB6fZYefzXcCM9oIoTrmYQRqcddh8NRp9TXiYPMunSo0ekDYLk4m q5hyFi5rDu84Gd4sjlKiyYnebhwdkk+Bx2E9b+Adev/FT/IQsltonASTSAgS8DJXkgCgFr WInak7bY9X9wE77y51rn2FVAUhULE08I6G/9d/FIteXVPIcecPSjdh4ZVx+nKQJdjFOpU1 3WhwjU+BiXiD9wEri6eSEEMcq+qwObwR58uTz4pUDGekjQI81xyniwZNt7hEzhTKp1hTry 993fFwYdoOw9ypzddb+A8PgmfVYCfoee0fLvOtSJaYmT0mWpVrSjxmAZSePfDQ== From: Miquel Raynal To: "Mahapatra, Amit Kumar" Cc: "richard@nod.at" , "vigneshr@ti.com" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "linux-mtd@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "git (AMD-Xilinx)" , "amitrkcian2002@gmail.com" , Bernhard Frauendienst Subject: Re: [PATCH v12 3/3] mtd: Add driver for concatenating devices In-Reply-To: (Amit Kumar Mahapatra's message of "Wed, 21 May 2025 06:13:32 +0000") References: <20250205133730.273985-1-amit.kumar-mahapatra@amd.com> <20250205133730.273985-4-amit.kumar-mahapatra@amd.com> <8734fa8hed.fsf@bootlin.com> <87o6vyjgfl.fsf@bootlin.com> <87o6vsejke.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Mon, 26 May 2025 10:10:39 +0200 Message-ID: <87ecwb3i80.fsf@bootlin.com> MIME-Version: 1.0 X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddujedttdculddtuddrgeefvddrtddtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghffgffkfggtgfgsehtqhertddtreejnecuhfhrohhmpefoihhquhgvlhcutfgrhihnrghluceomhhiqhhuvghlrdhrrgihnhgrlhessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepffeghfejtdefieeguddukedujeektdeihfelleeuieeuveehkedvleduheeivdefnecukfhppeeltddrkeelrdduieefrdduvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledtrdekledrudeifedruddvjedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhiqhhuvghlrdhrrgihnhgrlhessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepuddvpdhrtghpthhtoheprghmihhtrdhkuhhmrghrqdhmrghhrghprghtrhgrsegrmhgurdgtohhmpdhrtghpthhtoheprhhitghhrghrugesnhhougdrrghtpdhrtghpthhtohepvhhighhnvghshhhrsehtihdrtghomhdprhgtphhtthhopehrohgshheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepkhhriihkodgutheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohept ghonhhorhdoughtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhmthgusehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdhrtghpthhtohepuggvvhhitggvthhrvggvsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250526_011043_285421_F84A5A6D X-CRM114-Status: GOOD ( 26.62 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gMjEvMDUvMjAyNSBhdCAwNjoxMzozMiBHTVQsICJNYWhhcGF0cmEsIEFtaXQgS3VtYXIiIDxh bWl0Lmt1bWFyLW1haGFwYXRyYUBhbWQuY29tPiB3cm90ZToKCj4gW0FNRCBPZmZpY2lhbCBVc2Ug T25seSAtIEFNRCBJbnRlcm5hbCBEaXN0cmlidXRpb24gT25seV0KPgo+PiBPbiAxMy8wNS8yMDI1 IGF0IDE0OjQ1OjM5IEdNVCwgIk1haGFwYXRyYSwgQW1pdCBLdW1hciIgPGFtaXQua3VtYXItCj4+ IG1haGFwYXRyYUBhbWQuY29tPiB3cm90ZToKPj4KPj4gPiBbQU1EIE9mZmljaWFsIFVzZSBPbmx5 IC0gQU1EIEludGVybmFsIERpc3RyaWJ1dGlvbiBPbmx5XQo+PiA+Cj4+ID4gSGVsbG8gTWlxdWVs LAo+PiA+Cj4+ID4+ID4+ID4gKyAgICAgICAgICAgbXRkLT5kZXYucGFyZW50ID0gY29uY2F0LT5z dWJkZXZbMF0tPmRldi5wYXJlbnQ7Cj4+ID4+ID4+ID4gKyAgICAgICAgICAgbXRkLT5kZXYgPSBj b25jYXQtPnN1YmRldlswXS0+ZGV2Owo+PiA+PiA+PiA+ICsKPj4gPj4gPj4gPiArICAgICAgICAg ICAvKiBSZWdpc3RlciB0aGUgcGxhdGZvcm0gZGV2aWNlICovCj4+ID4+ID4+ID4gKyAgICAgICAg ICAgcmV0ID0gbXRkX2RldmljZV9yZWdpc3RlcihtdGQsIE5VTEwsIDApOwo+PiA+PiA+PiA+ICsg ICAgICAgICAgIGlmIChyZXQpCj4+ID4+ID4+ID4gKyAgICAgICAgICAgICAgICAgICBnb3RvIGRl c3Ryb3lfY29uY2F0Owo+PiA+PiA+PiA+ICsgICB9Cj4+ID4+ID4+ID4gKwo+PiA+PiA+PiA+ICsg ICByZXR1cm4gMDsKPj4gPj4gPj4gPiArCj4+ID4+ID4+ID4gK2Rlc3Ryb3lfY29uY2F0Ogo+PiA+ PiA+PiA+ICsgICBtdGRfY29uY2F0X2Rlc3Ryb3kobXRkKTsKPj4gPj4gPj4gPiArCj4+ID4+ID4+ ID4gKyAgIHJldHVybiByZXQ7Cj4+ID4+ID4+ID4gK30KPj4gPj4gPj4gPiArCj4+ID4+ID4+ID4g K2xhdGVfaW5pdGNhbGwobXRkX3ZpcnRfY29uY2F0X2NyZWF0ZV9qb2luKTsKPj4gPj4gPj4KPj4g Pj4gPj4gVGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gZG9lcyBub3Qgc3VwcG9ydCBwcm9iZSBk ZWZlcnJhbHMsIEkKPj4gPj4gPj4gYmVsaWV2ZSBpdCBzaG91bGQgYmUgaGFuZGxlZC4KPj4gPj4g Pgo+PiA+PiA+IEkgc2VlIHRoYXQgdGhlIHBhcnNlX210ZF9wYXJ0aXRpb25zKCkgQVBJIGNhbiBy ZXR1cm4gLUVQUk9CRV9ERUZFUgo+PiA+PiA+IGR1cmluZyBNVEQgZGV2aWNlIHJlZ2lzdHJhdGlv biwgYnV0IHRoaXMgYmVoYXZpb3IgaXMgc3BlY2lmaWMgdG8KPj4gPj4gPiB0aGUgcGFyc2VfcWNv bXNtZW1fcGFydCBwYXJzZXIuIE5vbmUgb2YgdGhlIG90aGVyIHBhcnNlcnMgYXBwZWFyIHRvCj4+ ID4+ID4gc3VwcG9ydCBwcm9iZSBkZWZlcnJhbC4gQXMgZGlzY3Vzc2VkIGluIFJGQyBbMV0sIHRo ZSB2aXJ0dWFsIGNvbmNhdAo+PiA+PiA+IGZlYXR1cmUgaXMgcHVyZWx5IGEgZml4ZWQtcGFydGl0 aW9uIGNhcGFiaWxpdHksIGFuZCBiYXNlZCBvbiBteQo+PiA+PiA+IHVuZGVyc3RhbmRpbmcsIHRo ZSBmaXhlZC1wYXJ0aXRpb24gcGFyc2VyIGRvZXMgbm90IHN1cHBvcnQgcHJvYmUgZGVmZXJyYWwu Cj4+ID4+ID4gUGxlYXNlIGxldCBtZSBrbm93IGlmIHlvdSBjYW4gdGhpbmsgb2YgYW55IG90aGVy IHByb2JlIGRlZmVycmFsCj4+ID4+ID4gc2NlbmFyaW9zIHRoYXQgbWlnaHQgaW1wYWN0IHRoZSB2 aXJ0dWFsIGNvbmNhdCBkcml2ZXIuCj4+ID4+Cj4+ID4+IFRoYXQncyB0cnVlLCBidXQgSSBraW5k IG9mIGRpc2xpa2UgdGhlIGxhdGVfaW5pdGNhbGwsIEkgZmVhciBpdCBtaWdodCBicmVhayBpbiBj cmVhdGl2ZQo+PiB3YXlzLgo+PiA+Cj4+ID4gSSB1bmRlcnN0YW5kLCBidXQgc2luY2Ugd2UgcmVx dWlyZSB0aGUgcGFydGl0aW9uIGluZm9ybWF0aW9uIHRvIGJlCj4+ID4gYXZhaWxhYmxlLCBsYXRl X2luaXRjYWxsIHNlZW1zIHRvIGJlIHRoZSBtb3N0IHN1aXRhYmxlIGNob2ljZSBhbW9uZwo+PiA+ IHRoZSBpbml0Y2FsbCBsZXZlbHPigJRpZiB3ZSBkZWNpZGUgdG8gcHJvY2VlZCB3aXRoIHVzaW5n IGFuIGluaXRjYWxsLgo+PiA+IFJlZ2FyZGluZyBwb3RlbnRpYWwgZmFpbHVyZXMsIGFzIGZhciBh cyBJIGNhbiB0ZWxsLCB0aGUgb3BlcmF0aW9uCj4+ID4gd291bGQgZmFpbCBpZiwgYXQgdGhlIHRp bWUgb2YgY29uY2F0ZW5hdGlvbiwgb25lIG9yIG1vcmUgb2YgdGhlIE1URAo+PiA+IGRldmljZXMg aW52b2x2ZWQgaW4gdGhlIGNvbmNhdCBhcmUgbm90IHlldCBhdmFpbGFibGUuIEluIHN1Y2ggYQo+ PiA+IHNjZW5hcmlvLCB3ZSBjYW4gaXNzdWUgYSBrZXJuZWwgd2FybmluZyBhbmQgZXhpdCBncmFj ZWZ1bGx5LiBCdXQsCj4+ID4gSG93ZXZlciwgaWYgeW91IHByZWZlciB0byBtb3ZlIGF3YXkgZnJv bSB1c2luZyBpbml0Y2FsbHMgYW5kIGhhdmUgYW4KPj4gPiBhbHRlcm5hdGl2ZSBpbXBsZW1lbnRh dGlvbiBhcHByb2FjaCBpbiBtaW5kLCBwbGVhc2UgbGV0IHVzIGtub3cuCj4+Cj4+IEkgYW0gc29y cnkgYnV0IHRoaXMgZG9lcyBub3Qgd29yayB3aXRoIG1vZHVsZXMsIGFuZCB3ZSBjYW5ub3QgaWdu b3JlIHRoaXMgY2FzZSBJCj4+IGJlbGlldmUuIE1vcmUgc3BlY2lmaWNhbGx5LCBpZiBhIGNvbnRy b2xsZXIgcHJvYmUgaXMgZGVmZXJyZWQgKHdpdGggRVBST0JFX0RFRkVSCj4+IG9yIGp1c3QgcHJl dmVudGVkIGJlY2F1c2Ugc29tZSBkZXBlbmRlbmNpZXMgYXJlIG5vdCB5ZXQgc2F0aXNmaWVkKSwg eW91J2xsIGdldAo+PiBpbmNvcnJlY3RseSBkZWZpbmVkIG10ZCBkZXZpY2VzLgo+Cj4gT2ssIGFu IGFsdGVybmF0aXZlIHNvbHV0aW9uIGNvdWxkIGJlIHRvIHJlbW92ZSB0aGUgaW5pdGNhbGwgcmVn aXN0cmF0aW9uCj4gYW5kIGluc3RlYWQgaW52b2tlIG10ZF92aXJ0X2NvbmNhdF9jcmVhdGVfam9p bigp4oCUd2hpY2ggd2FzIHByZXZpb3VzbHkKPiByZWdpc3RlcmVkIGFzIGEgbGF0ZV9pbml0Y2Fs bOKAlGRpcmVjdGx5IGZyb20gbXRkX2RldmljZV9wYXJzZV9yZWdpc3RlcigpLgo+IEkgYmVsaWV2 ZSB0aGlzIGFwcHJvYWNoIHdvdWxkIGFkZHJlc3MgYm90aCBvZiB5b3VyIGNvbmNlcm5zIHJlZ2Fy ZGluZwo+IG1vZHVsZSBzdXBwb3J0IGFuZCBwcm9iZSBkZWZlcnJhbC4gQWRkaXRpb25hbGx5LCB3 ZSBjb3VsZCBjb25zaWRlcgo+IG1vdmluZyB0aGUgZW50aXJlIGNvZGUgZnJvbSBtdGRfdmlydF9j b25jYXQuYyBpbnRvIG10ZGNvbmNhdC5jLgo+IFBsZWFzZSBsZXQgdXMga25vdyB5b3VyIHRha2Ug b24gdGhpcy4KCldoYXQgd291bGQgdGhpcyBicmluZz8KCk1heWJlIHdlIHNob3VsZCB0cmlnZ2Vy IHNvbWUga2luZCBvZiBub3RpZmllciBhZnRlciByZWdpc3RlcmluZyBhbiBtdGQKZGV2aWNlIGFu ZCBpbiB0aGVyZSBhdHRlbXB0IHRvIGdhdGhlciBhbGwgbXRkIGRldmljZXMgcmVxdWlyZWQgZm9y IHRoZQpjb25jYXRlbmF0aW9uLiBDYW4geW91IHBsZWFzZSBwcm9wb3NlIHNvbWV0aGluZyBsaWtl IHRoYXQ/CgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54CE14D599; Mon, 26 May 2025 08:10:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748247044; cv=none; b=B/Bpe7Uco0y537fw3W2d0BQKXt3Q4BJ0rJVU4TfF7NBO9uWz/Zu3/RMKHWwtFVPDYSvgu5+MqH9HYgImWcJYAE4ZX3ym0qax/PyPYLsKY+8BaC1tvap8wiWwvU9tTVX8sigCHq4+dFyvONl7gbKL4m6sbqhO/kWsLvzOrIEM7a8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748247044; c=relaxed/simple; bh=NKtlm0wAjMgQp9P8UItt7YMIPJ6Wz4vKYpgBLkGvLq0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=LEcFAf5717CyBETpP5xjRdxgLbvQhyQrVgOTomTNVJ53YIXVIT/03OAvTg/d84Es39OEvwmzZVRHRODyWbg4/BYhFrAtmCmFSb87nYKmDDDILcocksxpXM3mal1fcgIiQYrdNmuteUIDdMV65zvKzBLeG57dMzAEQ7BKQkU2BYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=V392rnYF; arc=none smtp.client-ip=217.70.183.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="V392rnYF" Received: by mail.gandi.net (Postfix) with ESMTPSA id 09B0F432A2; Mon, 26 May 2025 08:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1748247040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GuNkJwVVyWMP6VzsZqlzIYpsiMS21Kc27Fn5oFSy5nU=; b=V392rnYF+b8ejLtIgotB6fZYefzXcCM9oIoTrmYQRqcddh8NRp9TXiYPMunSo0ekDYLk4m q5hyFi5rDu84Gd4sjlKiyYnebhwdkk+Bx2E9b+Adev/FT/IQsltonASTSAgS8DJXkgCgFr WInak7bY9X9wE77y51rn2FVAUhULE08I6G/9d/FIteXVPIcecPSjdh4ZVx+nKQJdjFOpU1 3WhwjU+BiXiD9wEri6eSEEMcq+qwObwR58uTz4pUDGekjQI81xyniwZNt7hEzhTKp1hTry 993fFwYdoOw9ypzddb+A8PgmfVYCfoee0fLvOtSJaYmT0mWpVrSjxmAZSePfDQ== From: Miquel Raynal To: "Mahapatra, Amit Kumar" Cc: "richard@nod.at" , "vigneshr@ti.com" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "linux-mtd@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "git (AMD-Xilinx)" , "amitrkcian2002@gmail.com" , Bernhard Frauendienst Subject: Re: [PATCH v12 3/3] mtd: Add driver for concatenating devices In-Reply-To: (Amit Kumar Mahapatra's message of "Wed, 21 May 2025 06:13:32 +0000") References: <20250205133730.273985-1-amit.kumar-mahapatra@amd.com> <20250205133730.273985-4-amit.kumar-mahapatra@amd.com> <8734fa8hed.fsf@bootlin.com> <87o6vyjgfl.fsf@bootlin.com> <87o6vsejke.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Mon, 26 May 2025 10:10:39 +0200 Message-ID: <87ecwb3i80.fsf@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddujedttdculddtuddrgeefvddrtddtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghffgffkfggtgfgsehtqhertddtreejnecuhfhrohhmpefoihhquhgvlhcutfgrhihnrghluceomhhiqhhuvghlrdhrrgihnhgrlhessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepffeghfejtdefieeguddukedujeektdeihfelleeuieeuveehkedvleduheeivdefnecukfhppeeltddrkeelrdduieefrdduvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledtrdekledrudeifedruddvjedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhiqhhuvghlrdhrrgihnhgrlhessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepuddvpdhrtghpthhtoheprghmihhtrdhkuhhmrghrqdhmrghhrghprghtrhgrsegrmhgurdgtohhmpdhrtghpthhtoheprhhitghhrghrugesnhhougdrrghtpdhrtghpthhtohepvhhighhnvghshhhrsehtihdrtghomhdprhgtphhtthhopehrohgshheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepkhhriihkodgutheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohept ghonhhorhdoughtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhmthgusehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdhrtghpthhtohepuggvvhhitggvthhrvggvsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-GND-Sasl: miquel.raynal@bootlin.com On 21/05/2025 at 06:13:32 GMT, "Mahapatra, Amit Kumar" wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > >> On 13/05/2025 at 14:45:39 GMT, "Mahapatra, Amit Kumar" > mahapatra@amd.com> wrote: >> >> > [AMD Official Use Only - AMD Internal Distribution Only] >> > >> > Hello Miquel, >> > >> >> >> > + mtd->dev.parent =3D concat->subdev[0]->dev.parent; >> >> >> > + mtd->dev =3D concat->subdev[0]->dev; >> >> >> > + >> >> >> > + /* Register the platform device */ >> >> >> > + ret =3D mtd_device_register(mtd, NULL, 0); >> >> >> > + if (ret) >> >> >> > + goto destroy_concat; >> >> >> > + } >> >> >> > + >> >> >> > + return 0; >> >> >> > + >> >> >> > +destroy_concat: >> >> >> > + mtd_concat_destroy(mtd); >> >> >> > + >> >> >> > + return ret; >> >> >> > +} >> >> >> > + >> >> >> > +late_initcall(mtd_virt_concat_create_join); >> >> >> >> >> >> The current implementation does not support probe deferrals, I >> >> >> believe it should be handled. >> >> > >> >> > I see that the parse_mtd_partitions() API can return -EPROBE_DEFER >> >> > during MTD device registration, but this behavior is specific to >> >> > the parse_qcomsmem_part parser. None of the other parsers appear to >> >> > support probe deferral. As discussed in RFC [1], the virtual concat >> >> > feature is purely a fixed-partition capability, and based on my >> >> > understanding, the fixed-partition parser does not support probe de= ferral. >> >> > Please let me know if you can think of any other probe deferral >> >> > scenarios that might impact the virtual concat driver. >> >> >> >> That's true, but I kind of dislike the late_initcall, I fear it might= break in creative >> ways. >> > >> > I understand, but since we require the partition information to be >> > available, late_initcall seems to be the most suitable choice among >> > the initcall levels=E2=80=94if we decide to proceed with using an init= call. >> > Regarding potential failures, as far as I can tell, the operation >> > would fail if, at the time of concatenation, one or more of the MTD >> > devices involved in the concat are not yet available. In such a >> > scenario, we can issue a kernel warning and exit gracefully. But, >> > However, if you prefer to move away from using initcalls and have an >> > alternative implementation approach in mind, please let us know. >> >> I am sorry but this does not work with modules, and we cannot ignore thi= s case I >> believe. More specifically, if a controller probe is deferred (with EPRO= BE_DEFER >> or just prevented because some dependencies are not yet satisfied), you'= ll get >> incorrectly defined mtd devices. > > Ok, an alternative solution could be to remove the initcall registration > and instead invoke mtd_virt_concat_create_join()=E2=80=94which was previo= usly > registered as a late_initcall=E2=80=94directly from mtd_device_parse_regi= ster(). > I believe this approach would address both of your concerns regarding > module support and probe deferral. Additionally, we could consider > moving the entire code from mtd_virt_concat.c into mtdconcat.c. > Please let us know your take on this. What would this bring? Maybe we should trigger some kind of notifier after registering an mtd device and in there attempt to gather all mtd devices required for the concatenation. Can you please propose something like that? Thanks, Miqu=C3=A8l