From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Marek Vasut <marex@denx.de>, u-boot@lists.denx.de
Cc: Marek Vasut <marex@denx.de>, Dragan Simic <dsimic@manjaro.org>,
Joe Hershberger <joe.hershberger@ni.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v3 1/2] env: mmc: Make redundant env in both eMMC boot partitions consider DT properties
Date: Tue, 25 Feb 2025 17:30:47 +0100 [thread overview]
Message-ID: <87eczmf0lk.fsf@baylibre.com> (raw)
In-Reply-To: <20250221184732.202336-1-marex@denx.de>
Hi Marek,
Thank you for the patch.
On ven., févr. 21, 2025 at 19:47, Marek Vasut <marex@denx.de> wrote:
> Introduce a new function mmc_env_is_redundant_in_both_boot_hwparts()
> which replaces IS_ENABLED(ENV_MMC_HWPART_REDUND) and internally does
> almost the same check as the macro which assigned ENV_MMC_HWPART_REDUND
> did, and call it in place of IS_ENABLED(ENV_MMC_HWPART_REDUND).
>
> The difference compared to IS_ENABLED(ENV_MMC_HWPART_REDUND) is
> in the last conditional, which does not do plain macro compare
> (CONFIG_ENV_OFFSET == CONFIG_ENV_OFFSET_REDUND), but instead does
> mmc_offset(mmc, 0) == mmc_offset(mmc, 1). If OF_CONTROL is not
> in use, this gets optimized back to original macro compare, but
> if OF_CONTROL is in use, this also takes into account the DT
> properties u-boot,mmc-env-offset and u-boot,mmc-env-offset-redundant.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
next prev parent reply other threads:[~2025-02-25 16:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 18:47 [PATCH v3 1/2] env: mmc: Make redundant env in both eMMC boot partitions consider DT properties Marek Vasut
2025-02-21 18:47 ` [PATCH v3 2/2] env: mmc: Clean up env_mmc_load() ifdeffery Marek Vasut
2025-02-24 9:48 ` Quentin Schulz
2025-02-24 17:50 ` Marek Vasut
2025-02-25 16:34 ` Mattijs Korpershoek
2025-02-24 10:01 ` [PATCH v3 1/2] env: mmc: Make redundant env in both eMMC boot partitions consider DT properties Quentin Schulz
2025-02-24 17:49 ` Marek Vasut
2025-02-25 9:58 ` Quentin Schulz
2025-02-25 16:30 ` Mattijs Korpershoek [this message]
2025-02-28 20:23 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eczmf0lk.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=dsimic@manjaro.org \
--cc=joe.hershberger@ni.com \
--cc=marex@denx.de \
--cc=quentin.schulz@cherry.de \
--cc=rasmus.villemoes@prevas.dk \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.