From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACF7EC02180 for ; Mon, 13 Jan 2025 13:04:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tXK6Y-00016T-4c; Mon, 13 Jan 2025 08:03:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tXK61-0000zQ-Qv; Mon, 13 Jan 2025 08:03:16 -0500 Received: from smtp-out2.suse.de ([195.135.223.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tXK5z-0007T9-AS; Mon, 13 Jan 2025 08:03:08 -0500 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7134B1F381; Mon, 13 Jan 2025 13:03:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736773385; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+MQjyhWBolFPSTE7oSoabfxCyZpAlU1xbcCwG4thAgo=; b=0goaMf41NCpgesSXxY5fYlHkybFrLansI61P6eLJb3xfYGB+JrJD9P10EQ1h7zvbp49aGe OFieRIBz1cejMyysBnmWvNaEU7DCnKnaLev5vmWyWg2Qd6sH/kxGx1JT3hyrWgfU7Oq/e/ qd1SekyAk2vz+rTualmiLbShStlDeNo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736773385; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+MQjyhWBolFPSTE7oSoabfxCyZpAlU1xbcCwG4thAgo=; b=d7bRQoTYg+QI2nHVdILRD4wkdbkRGJqXi3J6GRPXcSmStx9vt4470xn29DVZGITv4Y313B Eo2dhemXyYADlsDQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736773385; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+MQjyhWBolFPSTE7oSoabfxCyZpAlU1xbcCwG4thAgo=; b=0goaMf41NCpgesSXxY5fYlHkybFrLansI61P6eLJb3xfYGB+JrJD9P10EQ1h7zvbp49aGe OFieRIBz1cejMyysBnmWvNaEU7DCnKnaLev5vmWyWg2Qd6sH/kxGx1JT3hyrWgfU7Oq/e/ qd1SekyAk2vz+rTualmiLbShStlDeNo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736773385; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+MQjyhWBolFPSTE7oSoabfxCyZpAlU1xbcCwG4thAgo=; b=d7bRQoTYg+QI2nHVdILRD4wkdbkRGJqXi3J6GRPXcSmStx9vt4470xn29DVZGITv4Y313B Eo2dhemXyYADlsDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id ED14A13876; Mon, 13 Jan 2025 13:03:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id S/PdKwgPhWcKHQAAD6G6ig (envelope-from ); Mon, 13 Jan 2025 13:03:04 +0000 From: Fabiano Rosas To: Michael Tokarev , Thomas Huth , qemu-devel@nongnu.org Cc: Peter Xu , qemu-stable Subject: Re: [PATCH v3 3/7] migration: Fix parsing of s390 stream In-Reply-To: References: <20250109185249.23952-1-farosas@suse.de> <20250109185249.23952-4-farosas@suse.de> <35911935-6f5c-40a3-aa73-3586dfdf3268@tls.msk.ru> <3cc941b1-b09d-4076-9234-9a385c762d3f@redhat.com> Date: Mon, 13 Jan 2025 10:03:02 -0300 Message-ID: <87ed16hnnd.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; MISSING_XM_UA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] Received-SPF: pass client-ip=195.135.223.131; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Michael Tokarev writes: > 13.01.2025 11:19, Thomas Huth wrote: >> On 13/01/2025 08.51, Michael Tokarev wrote: > >>> Picked up: >>> >>> =C2=A0=C2=A01/7 migration: Add more error handling to analyze-migration= .py >>> =C2=A0=C2=A03/7 migration: Fix parsing of s390 stream >>> =C2=A0=C2=A07/7 s390x: Fix CSS migration >>> >>> but still getting the same error: >>> >>> =C2=A0=C2=A0https://gitlab.com/mjt0k/qemu/-/jobs/8832218999 (9.2 branch) >>> =C2=A0=C2=A0https://gitlab.com/mjt0k/qemu/-/jobs/8832224338 (9.1 branch) >>=20 >> Blindly guessing: You need now patch 4/7 and 5/7, too? ... hopefully Fab= iano could reply and point you to the exact set of patches that you need... > > Yes, after picking up ALL 7 out of 7 in this patchset (b/c even the > trivial 2/7, "migration: Remove unused argument in vmsd_desc_field_end", > is needed or else the subsequent fixes doesn't apply) it is now green > finally, eg, https://gitlab.com/mjt0k/qemu/-/jobs/8832849813 > > Fabiano, what do you think, - should the whole patchset be picked up > for 9.2 and 9.1? Yeah, sorry, I was focused on unbreaking the migration PR and added a bunch of patches without thinking of stable. So the s390x regression (1/7) is 9.1, but 9.0 already had the broken analyze-script.py (3/7) and the broken array compression code (4-6/7). We definitely need 1/7 for 9.1 and 9.2. The rest of the series is "just" to avoid breaking the tests. If you can apply it easily I think that's preferable. Otherwise maybe we could disable the analyze-migration.py test for stable? I can also work on a backport if needed. Let me know what you prefer. > > Thanks, > > /mjt