From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: tkuw584924@gmail.com, linux-mtd@lists.infradead.org,
richard@nod.at, vigneshr@ti.com, pratyush@kernel.org,
mwalle@kernel.org, kr.kim@skyhighmemory.com,
zhi.feng@skyhighmemory.com, Bacem.Daassi@infineon.com,
Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
Subject: Re: [PATCH v2 1/3] mtd: spinand: Remove write_enable_op() in markbad()
Date: Mon, 02 Dec 2024 18:08:06 +0100 [thread overview]
Message-ID: <87ed2q57yh.fsf@bootlin.com> (raw)
In-Reply-To: <a5c09a0a-7d63-4029-abb2-597ade1da74a@linaro.org> (Tudor Ambarus's message of "Fri, 22 Nov 2024 09:37:45 +0000")
Hello,
On 22/11/2024 at 09:37:45 GMT, Tudor Ambarus <tudor.ambarus@linaro.org> wrote:
> On 11/21/24 2:08 AM, tkuw584924@gmail.com wrote:
>> From: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
>>
>> We don't have to call spinand_write_enable_op() in spinand_markbad() as
>> it is called in spinand_write_page().
>
> Indeed. The patch is a follow up for:
> Fixes: b645ad39d568 ("mtd: spinand: Do not erase the block before
> writing a bad block marker")
Correct.
Takahiro, would you mind updating the commit log to mention that commit,
please? It makes sense to have it mentioned. Otherwise the series looks
good, I'll apply it once you send a v3.
> That commit removed spinand_erase_op(), but failed to remove
> spinand_write_enable_op() with it.
>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
>
> Miquel, shall the spinand_write_enable_op() call be moved into
> spinand_erase_op()?
Thanks a lot for the review!
spinand_erase_op() is just about the "op", not about handling an "mtd"
erase. It is called from spinand_erase() which already does the
spinand_write_enable_op() and I believe it makes more sense to keep it
there, so when we browse the code we don't need to enter the low-level
functions and immediately identify what operations we send to the chip
without surprises.
Cheers,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-12-02 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 2:08 [PATCH v2 0/3] mtd: spinand: Add support for SkyHigh S35ML-3 family tkuw584924
2024-11-21 2:08 ` [PATCH v2 1/3] mtd: spinand: Remove write_enable_op() in markbad() tkuw584924
2024-11-22 9:37 ` Tudor Ambarus
2024-12-02 17:08 ` Miquel Raynal [this message]
2024-11-21 2:08 ` [PATCH v2 2/3] mtd: spinand: Introduce a way to avoid raw access tkuw584924
2024-11-21 2:08 ` [PATCH v2 3/3] mtd: spinand: Add support for SkyHigh S35ML-3 family tkuw584924
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ed2q57yh.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=Bacem.Daassi@infineon.com \
--cc=Takahiro.Kuwano@infineon.com \
--cc=kr.kim@skyhighmemory.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tkuw584924@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
--cc=zhi.feng@skyhighmemory.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.