Re: [Buildroot] [PATCH 1/1] package/alsa-lib: add BR2_USE_MMU dependency

[Baruch Siach via buildroot <buildroot@buildroot.org>]

Hi Maxim,

On Fri, Nov 29 2024, Maxim Kochetkov via buildroot wrote:
> Build fails with:
> ucm_exec.c: In function 'uc_mgr_exec':
> ucm_exec.c:229:13: error: implicit declaration of function 'fork' [-Wimplicit-function-declaration]
>   229 |         p = fork();
>       |             ^~~~
>
> ucm uses fork() so add BR2_USE_MMU dependency for it.
>
> Fixes: https://autobuild.buildroot.org/results/a287d3eef7ea5ea9a85b5b35d14e3698df4ecd01/build-end.log
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> ---
>  package/alsa-lib/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/package/alsa-lib/Config.in b/package/alsa-lib/Config.in
> index 447916a29f..98b61896d4 100644
> --- a/package/alsa-lib/Config.in
> +++ b/package/alsa-lib/Config.in
> @@ -69,8 +69,12 @@ config BR2_PACKAGE_ALSA_LIB_SEQ
>  config BR2_PACKAGE_ALSA_LIB_UCM
>  	bool "ucm"
>  	default y
> +	depends on BR2_USE_MMU # fork()
>  	select BR2_PACKAGE_ALSA_LIB_MIXER
>  
> +comment "ucm needs a toolchain w/ fork support"
> +	depends on !BR2_USE_MMU
> +

BR2_USE_MMU describes the target platform. This is not a toolchain
option user can change. For this reason we don't add comments for this
dependency.

See section 18.2.4 in the Buildroot manual:

  https://buildroot.org/downloads/manual/manual.html

baruch

>  config BR2_PACKAGE_ALSA_LIB_ALISP
>  	bool "alisp"
>  	default y

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot