From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: u-boot@lists.denx.de
Cc: Sughosh Ganu <sughosh.ganu@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Tom Rini <trini@konsulko.com>,
Emil Kronborg <emil.kronborg@protonmail.com>
Subject: Re: [PATCH] scripts/Makefile.lib: do not include CONFIG_DEVICE_TREE_INCLUDES in dtsi_include_list
Date: Tue, 10 Sep 2024 13:25:16 +0200 [thread overview]
Message-ID: <87ed5riwdf.fsf@prevas.dk> (raw)
In-Reply-To: <20240903215936.2193393-1-rasmus.villemoes@prevas.dk> (Rasmus Villemoes's message of "Tue, 3 Sep 2024 23:59:36 +0200")
Rasmus Villemoes <rasmus.villemoes@prevas.dk> writes:
> The commit mentioned in Fixes broke the
> CONFIG_DEVICE_TREE_INCLUDES feature, with the result that any board
> setting any non-empty value for that fails to build.
>
FWIW, it's quite easy to reproduce, though I don't know if it makes
sense to pollute, say, sandbox_defconfig with this to keep it from
regressing. Anyway, just add include/h2g2.dtsi containing
/ {
config {
question = "Life, the Universe and Everything";
answer = <42>;
};
};
and add "h2g2.dtsi" to CONFIG_DEVICE_TREE_INCLUDES. Or put the file in
/tmp and add the absolute path "/tmp/h2g2.dtsi" to
CONFIG_DEVICE_TREE_INCLUDES.
I know we're close to release date, but I'd really appreciate if this
could make it into 2024.10. Yes, it's my fault for not noticing and
reporting sooner; the timing just happened to mean I had several
customers end up using 2023.10 (making use of
CONFIG_DEVICE_TREE_INCLUDES), the breakage happened in 2024.01, and I
hadn't had occasion to use this with newer u-boots since, until just
recently.
Rasmus
next prev parent reply other threads:[~2024-09-10 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 21:59 [PATCH] scripts/Makefile.lib: do not include CONFIG_DEVICE_TREE_INCLUDES in dtsi_include_list Rasmus Villemoes
2024-09-04 7:56 ` Emil Kronborg
2024-09-10 11:25 ` Rasmus Villemoes [this message]
2024-09-10 19:07 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ed5riwdf.fsf@prevas.dk \
--to=rasmus.villemoes@prevas.dk \
--cc=emil.kronborg@protonmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=sughosh.ganu@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.