Re: [PATCH] wifi: ath12k: Add WMI control path stats infra

[Kalle Valo <kvalo@kernel.org>]

Ramya Gnanasekar <quic_rgnanase@quicinc.com> writes:

> On 5/29/2024 11:39 PM, Ramya Gnanasekar wrote:
>> From: Rajat Soni <quic_rajson@quicinc.com>
>> 
>> Currently, firmware stats is requested by host through HTT interface.
>> Since HTT interface is already overloaded for data path stats,
>> leveraging control path to request other stats through WMI interface.
>> 
>> Add debugfs to request the stats and dump the stats forwarded by firmware.
>> 
>> ath12k
>> `-- pci-0000:06:00.0
>>     |-- mac0
>>         `-- wmi_ctrl_stats
>> 
>> This patch also adds support to request PDEV Tx stats, parse and dump
>> the data sent from firmware.
>> 
>> Usage:
>> echo <stats id> <action> > /sys/kernel/debug/ath12k/pci-0000\:06\:00.0/mac0/wmi_ctrl_stats
>> 
>> Sample:
>> echo 1 1 > /sys/kernel/debug/ath12k/pci-0000\:06\:00.0/mac0/wmi_ctrl_stats
>> cat /sys/kernel/debug/ath12k/pci-0000\:06\:00.0/mac0/wmi_ctrl_stats
>> WMI_CTRL_PATH_PDEV_TX_STATS:
>> fw_tx_mgmt_subtype =  0:0, 1:2, 2:0, 3:0, 4:0, 5:37, 6:0, 7:0, 8:908, 9:0, 10:0, 11:18, 12:2, 13:3, 14:0, 15:0,
>> fw_rx_mgmt_subtype =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0,
>> scan_fail_dfs_violation_time_ms = 0
>> nol_chk_fail_last_chan_freq = 0
>> nol_chk_fail_time_stamp_ms = 0
>> tot_peer_create_cnt = 7
>> tot_peer_del_cnt = 7
>> tot_peer_del_resp_cnt = 7
>> vdev_pause_fail_rt_to_sched_algo_fifo_full_cnt = 0
>> 
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>> 
>> Signed-off-by: Rajat Soni <quic_rajson@quicinc.com>
>> Co-developed-by: Ramya Gnanasekar <quic_rgnanase@quicinc.com>
>> Signed-off-by: Ramya Gnanasekar <quic_rgnanase@quicinc.com>
>> ---
>> Depends-On: [PATCH v2 3/5] wifi: ath12k: Fix Pdev id in HTT stats request for WCN7850
>> Link: https://lore.kernel.org/linux-wireless/20240510050806.514126-1-quic_rgnanase@quicinc.com

[removing over 600 lines unnecessary quotes]

> Please drop this patch. I'll send a re-based version

Dropped, thanks for letting us know. But please edit your quotes,
including the full patch in the reply makes the use of patchwork
practically unusable:

https://patchwork.kernel.org/project/linux-wireless/patch/20240529180920.1472003-1-quic_rgnanase@quicinc.com/

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches