From: Kalle Valo <kvalo@kernel.org>
To: Baochen Qiang <quic_bqiang@quicinc.com>
Cc: Rameshkumar Sundaram <quic_ramess@quicinc.com>,
<ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
Sriram R <quic_srirrama@quicinc.com>
Subject: Re: [PATCH v4 1/3] wifi: ath12k: prepare vif data structure for MLO handling
Date: Tue, 18 Jun 2024 11:37:50 +0300 [thread overview]
Message-ID: <87ed8umysh.fsf@kernel.org> (raw)
In-Reply-To: <3754f5f3-0e67-4c5e-9b56-888ad5071622@quicinc.com> (Baochen Qiang's message of "Tue, 18 Jun 2024 15:47:46 +0800")
Baochen Qiang <quic_bqiang@quicinc.com> writes:
>> +static inline struct ieee80211_vif *ath12k_vif_to_vif(struct ath12k_vif *ahvif)
>
> better naming as ath12k_ahvif_to_vif()?
Thanks a lot for the review, I appreciate it. But please edit your
quotes, having thousands of lines of quotes makes use of patchwork
practically impossible:
https://patchwork.kernel.org/project/linux-wireless/patch/20240617131650.3288118-2-quic_ramess@quicinc.com/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-06-18 8:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 13:16 [PATCH v4 0/3] wifi: ath12k: prepare vif and sta datastructure Rameshkumar Sundaram
2024-06-17 13:16 ` [PATCH v4 1/3] wifi: ath12k: prepare vif data structure for MLO handling Rameshkumar Sundaram
2024-06-18 7:47 ` Baochen Qiang
2024-06-18 8:37 ` Kalle Valo [this message]
2024-06-18 10:18 ` Baochen Qiang
2024-06-20 16:52 ` Rameshkumar Sundaram
2024-06-17 13:16 ` [PATCH v4 2/3] wifi: ath12k: pass ath12k_link_vif instead of vif/ahvif Rameshkumar Sundaram
2024-06-17 13:16 ` [PATCH v4 3/3] wifi: ath12k: prepare sta data structure for MLO handling Rameshkumar Sundaram
2024-06-18 10:19 ` Baochen Qiang
2024-06-20 16:57 ` Rameshkumar Sundaram
2024-06-18 10:23 ` Baochen Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ed8umysh.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_bqiang@quicinc.com \
--cc=quic_ramess@quicinc.com \
--cc=quic_srirrama@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.