All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konrad.dybcio@linaro.org>,
	 Loic Poulain <loic.poulain@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	 Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	 wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
	 linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
	 Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 02/12] wifi: wcn36xx: make use of QCOM_FW_HELPER
Date: Fri, 31 May 2024 21:53:25 +0300	[thread overview]
Message-ID: <87ed9hvmmy.fsf@kernel.org> (raw)
In-Reply-To: <20240521-qcom-firmware-name-v1-2-99a6d32b1e5e@linaro.org> (Dmitry Baryshkov's message of "Tue, 21 May 2024 12:45:22 +0300")

Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes:

> Make the driver use qcom_fw_helper to autodetect the path to the
> calibration data file.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Not a fan of one sentence commit messages. It would be nice to explain a
bit more in the commit message, for instance answering to the question
'why?' and maybe provide a short example how this is supposed to work?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2024-05-31 18:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21  9:45 [PATCH 00/12] arm64: qcom: autodetect firmware paths Dmitry Baryshkov
2024-05-21  9:45 ` [PATCH 01/12] soc: qcom: add firmware name helper Dmitry Baryshkov
2024-05-21  9:52   ` neil.armstrong
2024-05-21 10:01     ` Dmitry Baryshkov
2024-05-21 11:20       ` Kalle Valo
2024-05-21 13:08         ` Dmitry Baryshkov
2024-05-22 22:48           ` Bjorn Andersson
2024-05-27 11:42             ` Dmitry Baryshkov
2024-05-29  2:28               ` Bjorn Andersson
2024-05-31 18:48                 ` Kalle Valo
2024-05-21  9:45 ` [PATCH 02/12] wifi: wcn36xx: make use of QCOM_FW_HELPER Dmitry Baryshkov
2024-05-31 18:53   ` Kalle Valo [this message]
2024-05-21  9:45 ` [PATCH 03/12] soc: qcom: wcnss_ctrl: " Dmitry Baryshkov
2024-05-21  9:45 ` [PATCH 04/12] remoteproc: qcom_q6v5_mss: switch to mbn files by default Dmitry Baryshkov
2024-05-21  9:45 ` [PATCH 05/12] remoteproc: qcom_q6v5_mss: make use of QCOM_FW_HELPER Dmitry Baryshkov
2024-05-21  9:45 ` [PATCH 06/12] remoteproc: qcom_q6v5_pas: switch to mbn files by default Dmitry Baryshkov
2024-05-21  9:49   ` neil.armstrong
2024-05-21 10:01     ` Dmitry Baryshkov
2024-05-21 19:40     ` Bjorn Andersson
2024-05-21  9:45 ` [PATCH 07/12] remoteproc: qcom_q6v5_pas: make use of QCOM_FW_HELPER Dmitry Baryshkov
2024-05-21  9:45 ` [PATCH 08/12] remoteproc: qcom_wcnss: switch to mbn files by default Dmitry Baryshkov
2024-05-21  9:45 ` [PATCH 09/12] remoteproc: qcom_wcnss: make use of QCOM_FW_HELPER Dmitry Baryshkov
2024-05-22 19:21   ` Jeff Johnson
2024-05-22 20:42     ` Dmitry Baryshkov
2024-05-21  9:45 ` [PATCH 10/12] " Dmitry Baryshkov
2024-05-21  9:45 ` [PATCH 11/12] arm64: dts: qcom: apq8016-sbc: drop firmware-name properties Dmitry Baryshkov
2024-05-21  9:45 ` [PATCH 12/12] arm64: dts: qcom: apq8096-db820c: " Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed9hvmmy.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh@kernel.org \
    --cc=wcn36xx@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.