All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	linux-sound@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
	Mark Brown <broonie@kernel.org>,
	Shengjiu Wang <shengjiu.wang@gmail.com>,
	Nicolas Dufresne <nicolas@ndufresne.ca>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Vinod Koul <vkoul@kernel.org>
Subject: Re: [RFC PATCH] ALSA: compress_offload: introduce passthrough operation mode
Date: Mon, 27 May 2024 13:10:46 +0200	[thread overview]
Message-ID: <87ed9na4sp.wl-tiwai@suse.de> (raw)
In-Reply-To: <e5300791-e702-4868-a442-94162f2e1a97@linux.intel.com>

On Mon, 27 May 2024 12:13:30 +0200,
Amadeusz Sławiński wrote:
> 
> > +static int snd_compr_task_status(struct snd_compr_stream *stream,
> > +					struct snd_compr_task_status *status)
> > +{
> > +	struct snd_compr_task_runtime *task;
> > +
> > +	task = snd_compr_find_task(stream, status->seqno);
> > +	if (task == NULL)
> > +		return -EINVAL;
> > +	status->output_size = task->output_size;
> > +	status->active = task->active ? 1 : 0;
> > +	status->finished = task->finished ? 1 : 0;
> 
> Not sure, but access to ->active and ->finished, feels to me like
> something that may require locking.

Or better to make it a single state field?


thanks,

Takashi

  reply	other threads:[~2024-05-27 11:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27  7:11 [RFC PATCH] ALSA: compress_offload: introduce passthrough operation mode Jaroslav Kysela
2024-05-27 10:13 ` Amadeusz Sławiński
2024-05-27 11:10   ` Takashi Iwai [this message]
2024-05-27 11:34     ` Jaroslav Kysela
2024-05-27 11:41   ` Jaroslav Kysela
2024-05-27 11:23 ` Takashi Iwai
2024-05-27 12:20   ` Jaroslav Kysela
2024-05-27 14:17 ` Pierre-Louis Bossart
     [not found]   ` <66bf7ad9-8680-4ed0-8e04-cac3ab701c46@perex.cz>
     [not found]     ` <8aa8609b-eb8c-43c8-89ac-94b1eda267fd@linux.intel.com>
2024-05-27 15:59       ` Jaroslav Kysela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed9na4sp.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=nicolas@ndufresne.ca \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=shengjiu.wang@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.