From: Thomas Gleixner <tglx@linutronix.de>
To: "Luck, Tony" <tony.luck@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Uros Bizjak <ubizjak@gmail.com>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
Arnd Bergmann <arnd@arndb.de>, Mateusz Guzik <mjguzik@gmail.com>,
Thomas Renninger <trenn@suse.de>,
Greg Kroah-Hartman <gregkh@suse.de>,
Andi Kleen <ak@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"patches@lists.linux.dev" <patches@lists.linux.dev>
Subject: RE: [PATCH v2] x86/cpu: Fix x86_match_cpu() to match just X86_VENDOR_INTEL
Date: Fri, 17 May 2024 22:42:44 +0200 [thread overview]
Message-ID: <87eda0jhkr.ffs@tglx> (raw)
In-Reply-To: <SJ1PR11MB60837E7CD8952271654EA379FCEE2@SJ1PR11MB6083.namprd11.prod.outlook.com>
On Fri, May 17 2024 at 18:17, Luck, Tony wrote:
>> I'm confused. Why not simply use say -1 for wildcard vendor match, -2
>> for no vendor ID (no CPUID or other known probing mechanism) and -3
>> for unrecognized vendor (vendor detectable but not known.)
>
> It was really convenient to have "0" be the wildcard for all of
> vendor, family, model, stepping, feature because users of
> x86_match_cpu() could just initialize the fields they cared about in
> the struct x86_cpu_id and have the compiler make the rest be 0
> automagically.
>
> But X86_VENDOR_INTEL being zero has always been a thorn in that scheme.
As all initializers are macro based, that's really a non-problem.
Thanks,
tglx
next prev parent reply other threads:[~2024-05-17 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 16:29 [PATCH v2] x86/cpu: Fix x86_match_cpu() to match just X86_VENDOR_INTEL Tony Luck
2024-05-16 21:27 ` Luck, Tony
2024-05-17 14:43 ` Borislav Petkov
2024-05-17 17:35 ` H. Peter Anvin
2024-05-17 18:17 ` Luck, Tony
2024-05-17 20:42 ` Thomas Gleixner [this message]
2024-05-17 20:41 ` Thomas Gleixner
2024-05-17 20:54 ` Luck, Tony
2024-05-20 23:33 ` H. Peter Anvin
2024-05-22 9:47 ` [tip: x86/urgent] " tip-bot2 for Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eda0jhkr.ffs@tglx \
--to=tglx@linutronix.de \
--cc=ak@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mjguzik@gmail.com \
--cc=patches@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=tony.luck@intel.com \
--cc=trenn@suse.de \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.