From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34D57C4345F for ; Sun, 28 Apr 2024 19:46:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id E9AFE60635; Sun, 28 Apr 2024 19:46:27 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id JAM_L1hYen9e; Sun, 28 Apr 2024 19:46:27 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org F17C960647 Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id F17C960647; Sun, 28 Apr 2024 19:46:26 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 7E9F71BF3DB for ; Sun, 28 Apr 2024 19:46:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 78D6860592 for ; Sun, 28 Apr 2024 19:46:14 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id LGTh1IrZd5-3 for ; Sun, 28 Apr 2024 19:46:13 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=217.70.183.194; helo=relay2-d.mail.gandi.net; envelope-from=peter@korsgaard.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 6EFA860635 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6EFA860635 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by smtp3.osuosl.org (Postfix) with ESMTPS id 6EFA860635 for ; Sun, 28 Apr 2024 19:46:13 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id BEB6A40002; Sun, 28 Apr 2024 19:46:11 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.96) (envelope-from ) id 1s1ATT-006hHa-0T; Sun, 28 Apr 2024 21:46:11 +0200 From: Peter Korsgaard To: Yann E. MORIN References: <20240401184812.E9A6184735@busybox.osuosl.org> Date: Sun, 28 Apr 2024 21:46:11 +0200 In-Reply-To: <20240401184812.E9A6184735@busybox.osuosl.org> (Yann E. MORIN's message of "Mon, 1 Apr 2024 17:03:17 +0200") Message-ID: <87edapb798.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-GND-Sasl: peter@korsgaard.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Subject: Re: [Buildroot] [git commit] support/download/check-hash: fix shellcheck errors X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Yann" == Yann E MORIN writes: > commit: https://git.buildroot.net/buildroot/commit/?id=9cb421c16f9aa026eabe050d94664c137f93eff5 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master > The hash files do not use trailing backslash \ to continue lines, so > we don't want them to be interpreted thusly, so we use 'read -r' > (SC2162). > The h_file is used twice in the same loop, once for reading from it, > and once just to print it, so there is no conflict (SC2094). > Integrer variables need not be quoted (SC2086). In any case, should > there be an actual issue and they be set empty, that would cause a > runtime issue, wether they be quoted or not. > Signed-off-by: Yann E. MORIN Committed to 2024.02.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot