All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Marc Zyngier <maz@kernel.org>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"biju.das.au" <biju.das.au@gmail.com>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 4/5] irqchip/renesas-rzg2l: Fix spurious IRQ
Date: Wed, 13 Mar 2024 16:42:42 +0100	[thread overview]
Message-ID: <87edcennnx.ffs@tglx> (raw)
In-Reply-To: <OSAPR01MB1587D16D699155C52A240E5B862A2@OSAPR01MB1587.jpnprd01.prod.outlook.com>

On Wed, Mar 13 2024 at 14:58, Biju Das wrote:
>> > -	raw_spin_lock(&priv->lock);
>> > +	raw_spin_lock_irqsave(&priv->lock, flags);
>> 
>> irq_set_type() is always called with irq_desc::lock held and interrupts disabled. What's exactly the
>> point of this change?
>
> Oops, in that case this change is not needed.
>
> HW manual mentions, interrupt should be disabled while setting the value. 
>
> I will drop this change in next version.

I fixed it up locally already. I'm going to merge 1-4 because those are
fixes (2/3 are preparatory). #5 wants a change log matching reality
though.

Thanks,

        tglx

  reply	other threads:[~2024-03-13 15:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 18:39 [PATCH v2 0/5] Fix spurious TINT IRQ and enhancements Biju Das
2024-03-05 18:39 ` [PATCH v2 1/5] irqchip/renesas-rzg2l: Flush posted write Biju Das
2024-03-05 18:39 ` [PATCH v2 2/5] irqchip/renesas-rzg2l: Rename rzg2l_tint_eoi() Biju Das
2024-03-05 18:39 ` [PATCH v2 3/5] irqchip/renesas-rzg2l: Rename rzg2l_irq_eoi() Biju Das
2024-03-05 18:39 ` [PATCH v2 4/5] irqchip/renesas-rzg2l: Fix spurious IRQ Biju Das
2024-03-13 14:38   ` Thomas Gleixner
2024-03-13 14:58     ` Biju Das
2024-03-13 15:42       ` Thomas Gleixner [this message]
2024-03-13 16:21         ` Biju Das
2024-03-05 18:39 ` [PATCH v2 5/5] irqchip/renesas-rzg2l: Use TIEN for enable/disable Biju Das
2024-03-13 15:40   ` Thomas Gleixner
2024-03-13 15:59     ` Biju Das
2024-03-14  8:59       ` Thomas Gleixner
2024-03-14  9:07         ` Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edcennnx.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=biju.das.au@gmail.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.