All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Het Gala <het.gala@nutanix.com>
Cc: qemu-devel@nongnu.org, "Peter Xu" <peterx@redhat.com>,
	"Fabiano Fidêncio" <fabiano@fidencio.org>
Subject: Re: [PATCH] qapi: Misc cleanups to migrate QAPIs
Date: Wed, 21 Feb 2024 07:57:26 +0100	[thread overview]
Message-ID: <87edd61ezt.fsf@pond.sub.org> (raw)
In-Reply-To: <20240216195659.189091-1-het.gala@nutanix.com> (Het Gala's message of "Fri, 16 Feb 2024 19:56:59 +0000")

You neglected to cc: migration maintainers; I'm doing that for you now.

Peter or Fabiano, please have a look.

Het Gala <het.gala@nutanix.com> writes:

> Signed-off-by: Het Gala <het.gala@nutanix.com>
> ---
>  qapi/migration.json | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 5a565d9b8d..5756e650b0 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1728,6 +1728,7 @@
>  #
>  # -> { "execute": "migrate", "arguments": { "uri": "tcp:0:4446" } }
>  # <- { "return": {} }
> +#
>  # -> { "execute": "migrate",
>  #      "arguments": {
>  #          "channels": [ { "channel-type": "main",
> @@ -1796,19 +1797,19 @@
>  #
>  #     3. The uri format is the same as for -incoming
>  #
> -#     5. For now, number of migration streams is restricted to one,
> +#     4. For now, number of migration streams is restricted to one,
>  #        i.e number of items in 'channels' list is just 1.
>  #
> -#     4. The 'uri' and 'channels' arguments are mutually exclusive;
> +#     5. The 'uri' and 'channels' arguments are mutually exclusive;
>  #        exactly one of the two should be present.
>  #
>  # Example:
>  #
>  # -> { "execute": "migrate-incoming",
> -#      "arguments": { "uri": "tcp::4446" } }
> +#      "arguments": { "uri": "tcp:0:4446" } }
>  # <- { "return": {} }
>  #
> -# -> { "execute": "migrate",
> +# -> { "execute": "migrate-incoming",
>  #      "arguments": {
>  #          "channels": [ { "channel-type": "main",
>  #                          "addr": { "transport": "socket",
> @@ -1817,7 +1818,7 @@
>  #                                    "port": "1050" } } ] } }
>  # <- { "return": {} }
>  #
> -# -> { "execute": "migrate",
> +# -> { "execute": "migrate-incoming",
>  #      "arguments": {
>  #          "channels": [ { "channel-type": "main",
>  #                          "addr": { "transport": "exec",
> @@ -1825,7 +1826,7 @@
>  #                                              "/some/sock" ] } } ] } }
>  # <- { "return": {} }
>  #
> -# -> { "execute": "migrate",
> +# -> { "execute": "migrate-incoming",
>  #      "arguments": {
>  #          "channels": [ { "channel-type": "main",
>  #                          "addr": { "transport": "rdma",



  reply	other threads:[~2024-02-21  6:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 19:56 [PATCH] qapi: Misc cleanups to migrate QAPIs Het Gala
2024-02-21  6:57 ` Markus Armbruster [this message]
2024-02-21  7:06   ` Het Gala
2024-02-21  8:23     ` Markus Armbruster
2024-02-21  8:26     ` Peter Xu
2024-02-21  8:30       ` Markus Armbruster
2024-02-21  9:58         ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edd61ezt.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=fabiano@fidencio.org \
    --cc=het.gala@nutanix.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.