From: Tobias Waldekranz <tobias@waldekranz.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: davem@davemloft.net, kuba@kernel.org, olteanv@gmail.com,
roopa@nvidia.com, razor@blackwall.org, bridge@lists.linux.dev,
netdev@vger.kernel.org, ivecera@redhat.com
Subject: Re: [PATCH net 1/2] net: switchdev: Add helper to check if an object event is pending
Date: Wed, 31 Jan 2024 14:31:50 +0100 [thread overview]
Message-ID: <87eddxtyrd.fsf@waldekranz.com> (raw)
In-Reply-To: <ZbpCA3kgoCKsdQ4J@nanopsycho>
On ons, jan 31, 2024 at 13:50, Jiri Pirko <jiri@resnulli.us> wrote:
> Wed, Jan 31, 2024 at 01:35:43PM CET, tobias@waldekranz.com wrote:
>>When adding/removing a port to/from a bridge, the port must be brought
>>up to speed with the current state of the bridge. This is done by
>>replaying all relevant events, directly to the port in question.
>
> Could you please use the imperative mood in your patch descriptions?
> That way, it is much easier to understand what is the current state of
> things and what you are actually changing.
>
> https://www.kernel.org/doc/html/v6.7/process/submitting-patches.html#describe-your-changes
>
> While at it, could you also fix your cover letter so the reader can
> actually tell what's the current state and what the patchset is doing?
Sure thing. Do you feel that this is enough of an issue that it blocks
you from doing a review of v1, or can I wait for more feedback and bake
it in with other changes?
next prev parent reply other threads:[~2024-01-31 13:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 12:35 [PATCH net 0/2] net: bridge: switchdev: Skip MDB replays of pending events Tobias Waldekranz
2024-01-31 12:35 ` [PATCH net 1/2] net: switchdev: Add helper to check if an object event is pending Tobias Waldekranz
2024-01-31 12:50 ` Jiri Pirko
2024-01-31 13:31 ` Tobias Waldekranz [this message]
2024-02-01 0:33 ` Vladimir Oltean
2024-02-01 7:45 ` Jiri Pirko
2024-01-31 13:34 ` Vladimir Oltean
2024-01-31 14:48 ` Tobias Waldekranz
2024-02-01 0:29 ` Vladimir Oltean
2024-01-31 12:35 ` [PATCH net 2/2] net: bridge: switchdev: Skip MDB replays of pending events Tobias Waldekranz
2024-01-31 13:51 ` Vladimir Oltean
2024-01-31 15:06 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eddxtyrd.fsf@waldekranz.com \
--to=tobias@waldekranz.com \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.