From: Jani Nikula <jani.nikula@linux.intel.com>
To: Vinod Govindapillai <vinod.govindapillai@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: ville.syrjala@intel.com
Subject: Re: [PATCH v1 2/2] drm/xe: Modify the cfb size to be page size aligned for FBC
Date: Fri, 12 Jan 2024 10:56:45 +0200 [thread overview]
Message-ID: <87edenszea.fsf@intel.com> (raw)
In-Reply-To: <20240110110009.28799-3-vinod.govindapillai@intel.com>
On Wed, 10 Jan 2024, Vinod Govindapillai <vinod.govindapillai@intel.com> wrote:
> drm_gem_private_object_init expect the object size be page size
> aligned. The xe_bo create functions do not update the size for
> any alignment requirements. So align cfb size to be page size
> aligned in xe stolen memory handling.
Please send this to the intel-xe mailing list.
BR,
Jani.
>
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> ---
> drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h
> index 888e7a87a925..bd233007c1b7 100644
> --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h
> @@ -19,6 +19,9 @@ static inline int i915_gem_stolen_insert_node_in_range(struct xe_device *xe,
> int err;
> u32 flags = XE_BO_CREATE_PINNED_BIT | XE_BO_CREATE_STOLEN_BIT;
>
> + if (align)
> + size = ALIGN(size, align);
> +
> bo = xe_bo_create_locked_range(xe, xe_device_get_root_tile(xe),
> NULL, size, start, end,
> ttm_bo_type_kernel, flags);
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-01-12 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 11:00 [PATCH v1 0/2] drm/xe: ensure fbc cfb size to be page size aligned Vinod Govindapillai
2024-01-10 11:00 ` [PATCH v1 1/2] drm/i915/display: use PAGE_SIZE macro for FBC cfb alloc Vinod Govindapillai
2024-01-11 13:44 ` Ville Syrjälä
2024-01-11 13:47 ` Govindapillai, Vinod
2024-01-11 13:59 ` Ville Syrjälä
2024-01-11 14:37 ` Govindapillai, Vinod
2024-01-10 11:00 ` [PATCH v1 2/2] drm/xe: Modify the cfb size to be page size aligned for FBC Vinod Govindapillai
2024-01-12 8:56 ` Jani Nikula [this message]
2024-01-12 8:58 ` Jani Nikula
2024-01-10 15:11 ` ✗ Fi.CI.SPARSE: warning for drm/xe: ensure fbc cfb size to be page size aligned Patchwork
2024-01-10 15:23 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-10 17:53 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edenszea.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@intel.com \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.