From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3EEE944E; Fri, 22 Dec 2023 07:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oltmanns.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oltmanns.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oltmanns.dev header.i=@oltmanns.dev header.b="yfTUqeG/" Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4SxK9d5hNTz9t37; Fri, 22 Dec 2023 08:46:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1703231173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QReCVjp65CghleerQ4Gsba57ap8mMcMDnWkb8OUPQus=; b=yfTUqeG/KzzUMlyxkh4Kr1ro6U3WNlOXHfwdMVxDWBWooswGbQ9Tf76tXJ/iDUuXhmukWP SJgx93NSfrGhfjIcfrnJaBUhBMYKNjpU/tL0CDkZqR6eiOVv6egqgSp3reUif8cA9W8j10 hveCBXVvJUucNi2OxlfVRWZViA8CsXrEa+B9w6jm2VC/HDdNvGmDFkuTWft9ydWk74somG GR7PfwtWATistc3dXQWwO/j0mUTDCIMdD5hVTeX4l+Ski4+Wjv5R02c/Bar5CgneCKfsss n+AkM9pdMdi1lXHOxQqD1gZLXtA0ua/0D0kaD1DUq8C8HcrN3hW1TRiUrOwb+A== References: <20231218-pinephone-pll-fixes-v1-0-e238b6ed6dc1@oltmanns.dev> <13411739.uLZWGnKmhe@jernej-laptop> <87il4t9wi1.fsf@oltmanns.dev> <2174554.Mh6RI2rZIc@jernej-laptop> From: Frank Oltmanns To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Samuel Holland , Guido =?utf-8?Q?G=C3=BCnther?= , Purism Kernel Team , Ondrej Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 4/5] clk: sunxi-ng: a64: Add constraints on PLL-VIDEO0's n/m ratio In-reply-to: <2174554.Mh6RI2rZIc@jernej-laptop> Date: Fri, 22 Dec 2023 08:46:01 +0100 Message-ID: <87edfellxi.fsf@oltmanns.dev> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4SxK9d5hNTz9t37 On 2023-12-20 at 16:12:42 +0100, Jernej =C5=A0krabec wrote: > Dne sreda, 20. december 2023 ob 08:09:28 CET je Frank Oltmanns napisal(a): >> >> On 2023-12-19 at 17:54:19 +0100, Jernej =C5=A0krabec wrote: >> > Dne ponedeljek, 18. december 2023 ob 14:35:22 CET je Frank Oltmanns na= pisal(a): >> >> The Allwinner A64 manual lists the following constraint for the >> >> PLL-VIDEO0 clock: 8 <=3D N/M <=3D 25 >> >> >> >> Use this constraint. >> >> >> >> Signed-off-by: Frank Oltmanns >> >> --- >> >> drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 8 ++++++-- >> >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> >> >> diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunx= i-ng/ccu-sun50i-a64.c >> >> index c034ac027d1c..75d839da446c 100644 >> >> --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> >> +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> >> @@ -68,7 +68,8 @@ static SUNXI_CCU_NM_WITH_SDM_GATE_LOCK(pll_audio_ba= se_clk, "pll-audio-base", >> >> BIT(28), /* lock */ >> >> CLK_SET_RATE_UNGATE); >> >> >> >> -static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST(pll_video0_c= lk, "pll-video0", >> >> +static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT_NM_RATIO(pll_vi= deo0_clk, >> >> + "pll-video0", >> >> "osc24M", 0x010, >> >> 192000000, /* Minimum rate */ >> >> 1008000000, /* Maximum rate */ >> >> @@ -80,7 +81,10 @@ static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CL= OSEST(pll_video0_clk, "pll-vid >> >> 297000000, /* frac rate 1 */ >> >> BIT(31), /* gate */ >> >> BIT(28), /* lock */ >> >> - CLK_SET_RATE_UNGATE); >> >> + CLK_SET_RATE_UNGATE, >> >> + CCU_FEATURE_FRACTIONAL | >> >> + CCU_FEATURE_CLOSEST_RATE, >> > >> > Above flags are unrelated change, put them in new patch if needed. >> >> You might notice that I am using a new macro for initializing the >> pll_video0_clk struct: >> New: SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT_NM_RATIO >> Old: SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST >> >> Setting the two CCU_FEATURE flags is part of the old initialization >> macro. >> >> I'll add SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_NM_RATIO_CLOSEST which >> hopefully resolves the confusion. > > I'm in doubt if we need so many macros. How many users of these macro we'= ll have? > I see that R40 SoC would also need same ratio limits, but other that that= , none? Ok, IIUC no additional macro and we keep this part of the patch as is. Best regards, Frank > > Best regards, > Jernej > >> >> Thanks, >> Frank >> >> > >> > Best regards, >> > Jernej >> > >> >> + 8, 25); /* min/max nm ratio */ >> >> >> >> static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK(pll_ve_clk, "pll-ve", >> >> "osc24M", 0x018, >> >> >> >> >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF01FC46CD8 for ; Fri, 22 Dec 2023 07:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:Cc:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=20XO2rALD2Ec5biGzwTjvgPDiqaLeejbZgVpIidypZk=; b=F3bmw4Vs+zGczPbpL8UPlGTXL3 rmV9jI5/TuGJyiCLiZpFbEQkfQ1X2jQPon7nrWZ0Cn/nPv9Nlfj3CDsjURrw6pMTJCyHzv9xeTz/I tyemgTPUiQfJtwgR+MC0m/DoDfAa4jVqB/kc3vZI/oYyQmLMbI+AqXft69GKcY9aNMcyXYJwhJekh R1PY/r5Do4kcnFCnrvc6a963l6jkp80llNW698ZNZHY9L1wngKydXIGmlEwowKdKVMHTcNk6oT95H SpiXUen0MPsmzD/e9mpTdi4260s5mE1mKvLy8mMC0fxlY7jgMHmn/3qFrLSgd0uery97zMiwvdf2r 7w+xlxaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rGaEi-005D7t-1y; Fri, 22 Dec 2023 07:46:24 +0000 Received: from mout-p-201.mailbox.org ([2001:67c:2050:0:465::201]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rGaEf-005D7U-1c for linux-arm-kernel@lists.infradead.org; Fri, 22 Dec 2023 07:46:23 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4SxK9d5hNTz9t37; Fri, 22 Dec 2023 08:46:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1703231173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QReCVjp65CghleerQ4Gsba57ap8mMcMDnWkb8OUPQus=; b=yfTUqeG/KzzUMlyxkh4Kr1ro6U3WNlOXHfwdMVxDWBWooswGbQ9Tf76tXJ/iDUuXhmukWP SJgx93NSfrGhfjIcfrnJaBUhBMYKNjpU/tL0CDkZqR6eiOVv6egqgSp3reUif8cA9W8j10 hveCBXVvJUucNi2OxlfVRWZViA8CsXrEa+B9w6jm2VC/HDdNvGmDFkuTWft9ydWk74somG GR7PfwtWATistc3dXQWwO/j0mUTDCIMdD5hVTeX4l+Ski4+Wjv5R02c/Bar5CgneCKfsss n+AkM9pdMdi1lXHOxQqD1gZLXtA0ua/0D0kaD1DUq8C8HcrN3hW1TRiUrOwb+A== References: <20231218-pinephone-pll-fixes-v1-0-e238b6ed6dc1@oltmanns.dev> <13411739.uLZWGnKmhe@jernej-laptop> <87il4t9wi1.fsf@oltmanns.dev> <2174554.Mh6RI2rZIc@jernej-laptop> From: Frank Oltmanns To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Samuel Holland , Guido =?utf-8?Q?G=C3=BCnther?= , Purism Kernel Team , Ondrej Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 4/5] clk: sunxi-ng: a64: Add constraints on PLL-VIDEO0's n/m ratio In-reply-to: <2174554.Mh6RI2rZIc@jernej-laptop> Date: Fri, 22 Dec 2023 08:46:01 +0100 Message-ID: <87edfellxi.fsf@oltmanns.dev> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4SxK9d5hNTz9t37 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231221_234621_889460_CE662AA6 X-CRM114-Status: GOOD ( 16.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjMtMTItMjAgYXQgMTY6MTI6NDIgKzAxMDAsIEplcm5laiDFoGtyYWJlYyA8amVybmVq LnNrcmFiZWNAZ21haWwuY29tPiB3cm90ZToKPiBEbmUgc3JlZGEsIDIwLiBkZWNlbWJlciAyMDIz IG9iIDA4OjA5OjI4IENFVCBqZSBGcmFuayBPbHRtYW5ucyBuYXBpc2FsKGEpOgo+Pgo+PiBPbiAy MDIzLTEyLTE5IGF0IDE3OjU0OjE5ICswMTAwLCBKZXJuZWogxaBrcmFiZWMgPGplcm5lai5za3Jh YmVjQGdtYWlsLmNvbT4gd3JvdGU6Cj4+ID4gRG5lIHBvbmVkZWxqZWssIDE4LiBkZWNlbWJlciAy MDIzIG9iIDE0OjM1OjIyIENFVCBqZSBGcmFuayBPbHRtYW5ucyBuYXBpc2FsKGEpOgo+PiA+PiBU aGUgQWxsd2lubmVyIEE2NCBtYW51YWwgbGlzdHMgdGhlIGZvbGxvd2luZyBjb25zdHJhaW50IGZv ciB0aGUKPj4gPj4gUExMLVZJREVPMCBjbG9jazogOCA8PSBOL00gPD0gMjUKPj4gPj4KPj4gPj4g VXNlIHRoaXMgY29uc3RyYWludC4KPj4gPj4KPj4gPj4gU2lnbmVkLW9mZi1ieTogRnJhbmsgT2x0 bWFubnMgPGZyYW5rQG9sdG1hbm5zLmRldj4KPj4gPj4gLS0tCj4+ID4+ICBkcml2ZXJzL2Nsay9z dW54aS1uZy9jY3Utc3VuNTBpLWE2NC5jIHwgOCArKysrKystLQo+PiA+PiAgMSBmaWxlIGNoYW5n ZWQsIDYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4gPj4KPj4gPj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvY2xrL3N1bnhpLW5nL2NjdS1zdW41MGktYTY0LmMgYi9kcml2ZXJzL2Nsay9z dW54aS1uZy9jY3Utc3VuNTBpLWE2NC5jCj4+ID4+IGluZGV4IGMwMzRhYzAyN2QxYy4uNzVkODM5 ZGE0NDZjIDEwMDY0NAo+PiA+PiAtLS0gYS9kcml2ZXJzL2Nsay9zdW54aS1uZy9jY3Utc3VuNTBp LWE2NC5jCj4+ID4+ICsrKyBiL2RyaXZlcnMvY2xrL3N1bnhpLW5nL2NjdS1zdW41MGktYTY0LmMK Pj4gPj4gQEAgLTY4LDcgKzY4LDggQEAgc3RhdGljIFNVTlhJX0NDVV9OTV9XSVRIX1NETV9HQVRF X0xPQ0socGxsX2F1ZGlvX2Jhc2VfY2xrLCAicGxsLWF1ZGlvLWJhc2UiLAo+PiA+PiAgCQkJCSAg ICAgICBCSVQoMjgpLAkvKiBsb2NrICovCj4+ID4+ICAJCQkJICAgICAgIENMS19TRVRfUkFURV9V TkdBVEUpOwo+PiA+Pgo+PiA+PiAtc3RhdGljIFNVTlhJX0NDVV9OTV9XSVRIX0ZSQUNfR0FURV9M T0NLX01JTl9NQVhfQ0xPU0VTVChwbGxfdmlkZW8wX2NsaywgInBsbC12aWRlbzAiLAo+PiA+PiAr c3RhdGljIFNVTlhJX0NDVV9OTV9XSVRIX0ZSQUNfR0FURV9MT0NLX01JTl9NQVhfRkVBVF9OTV9S QVRJTyhwbGxfdmlkZW8wX2NsaywKPj4gPj4gKwkJCQkJCSJwbGwtdmlkZW8wIiwKPj4gPj4gIAkJ CQkJCSJvc2MyNE0iLCAweDAxMCwKPj4gPj4gIAkJCQkJCTE5MjAwMDAwMCwJLyogTWluaW11bSBy YXRlICovCj4+ID4+ICAJCQkJCQkxMDA4MDAwMDAwLAkvKiBNYXhpbXVtIHJhdGUgKi8KPj4gPj4g QEAgLTgwLDcgKzgxLDEwIEBAIHN0YXRpYyBTVU5YSV9DQ1VfTk1fV0lUSF9GUkFDX0dBVEVfTE9D S19NSU5fTUFYX0NMT1NFU1QocGxsX3ZpZGVvMF9jbGssICJwbGwtdmlkCj4+ID4+ICAJCQkJCQky OTcwMDAwMDAsCS8qIGZyYWMgcmF0ZSAxICovCj4+ID4+ICAJCQkJCQlCSVQoMzEpLAkvKiBnYXRl ICovCj4+ID4+ICAJCQkJCQlCSVQoMjgpLAkvKiBsb2NrICovCj4+ID4+IC0JCQkJCQlDTEtfU0VU X1JBVEVfVU5HQVRFKTsKPj4gPj4gKwkJCQkJCUNMS19TRVRfUkFURV9VTkdBVEUsCj4+ID4+ICsJ CQkJCQlDQ1VfRkVBVFVSRV9GUkFDVElPTkFMIHwKPj4gPj4gKwkJCQkJCUNDVV9GRUFUVVJFX0NM T1NFU1RfUkFURSwKPj4gPgo+PiA+IEFib3ZlIGZsYWdzIGFyZSB1bnJlbGF0ZWQgY2hhbmdlLCBw dXQgdGhlbSBpbiBuZXcgcGF0Y2ggaWYgbmVlZGVkLgo+Pgo+PiBZb3UgbWlnaHQgbm90aWNlIHRo YXQgSSBhbSB1c2luZyBhIG5ldyBtYWNybyBmb3IgaW5pdGlhbGl6aW5nIHRoZQo+PiBwbGxfdmlk ZW8wX2NsayBzdHJ1Y3Q6Cj4+IE5ldzogU1VOWElfQ0NVX05NX1dJVEhfRlJBQ19HQVRFX0xPQ0tf TUlOX01BWF9GRUFUX05NX1JBVElPCj4+IE9sZDogU1VOWElfQ0NVX05NX1dJVEhfRlJBQ19HQVRF X0xPQ0tfTUlOX01BWF9DTE9TRVNUCj4+Cj4+IFNldHRpbmcgdGhlIHR3byBDQ1VfRkVBVFVSRSBm bGFncyBpcyBwYXJ0IG9mIHRoZSBvbGQgaW5pdGlhbGl6YXRpb24KPj4gbWFjcm8uCj4+Cj4+IEkn bGwgYWRkIFNVTlhJX0NDVV9OTV9XSVRIX0ZSQUNfR0FURV9MT0NLX01JTl9NQVhfTk1fUkFUSU9f Q0xPU0VTVCB3aGljaAo+PiBob3BlZnVsbHkgcmVzb2x2ZXMgdGhlIGNvbmZ1c2lvbi4KPgo+IEkn bSBpbiBkb3VidCBpZiB3ZSBuZWVkIHNvIG1hbnkgbWFjcm9zLiBIb3cgbWFueSB1c2VycyBvZiB0 aGVzZSBtYWNybyB3ZSdsbCBoYXZlPwo+IEkgc2VlIHRoYXQgUjQwIFNvQyB3b3VsZCBhbHNvIG5l ZWQgc2FtZSByYXRpbyBsaW1pdHMsIGJ1dCBvdGhlciB0aGF0IHRoYXQsIG5vbmU/CgpPaywgSUlV QyBubyBhZGRpdGlvbmFsIG1hY3JvIGFuZCB3ZSBrZWVwIHRoaXMgcGFydCBvZiB0aGUgcGF0Y2gg YXMgaXMuCgpCZXN0IHJlZ2FyZHMsCiAgRnJhbmsKCj4KPiBCZXN0IHJlZ2FyZHMsCj4gSmVybmVq Cj4KPj4KPj4gVGhhbmtzLAo+PiAgIEZyYW5rCj4+Cj4+ID4KPj4gPiBCZXN0IHJlZ2FyZHMsCj4+ ID4gSmVybmVqCj4+ID4KPj4gPj4gKwkJCQkJCTgsIDI1KTsJCS8qIG1pbi9tYXggbm0gcmF0aW8g Ki8KPj4gPj4KPj4gPj4gIHN0YXRpYyBTVU5YSV9DQ1VfTk1fV0lUSF9GUkFDX0dBVEVfTE9DSyhw bGxfdmVfY2xrLCAicGxsLXZlIiwKPj4gPj4gIAkJCQkJIm9zYzI0TSIsIDB4MDE4LAo+PiA+Pgo+ PiA+Pgo+PgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 761E8C41535 for ; Fri, 22 Dec 2023 07:46:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D83EE10E750; Fri, 22 Dec 2023 07:46:18 +0000 (UTC) Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C40E10E750 for ; Fri, 22 Dec 2023 07:46:16 +0000 (UTC) Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4SxK9d5hNTz9t37; Fri, 22 Dec 2023 08:46:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1703231173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QReCVjp65CghleerQ4Gsba57ap8mMcMDnWkb8OUPQus=; b=yfTUqeG/KzzUMlyxkh4Kr1ro6U3WNlOXHfwdMVxDWBWooswGbQ9Tf76tXJ/iDUuXhmukWP SJgx93NSfrGhfjIcfrnJaBUhBMYKNjpU/tL0CDkZqR6eiOVv6egqgSp3reUif8cA9W8j10 hveCBXVvJUucNi2OxlfVRWZViA8CsXrEa+B9w6jm2VC/HDdNvGmDFkuTWft9ydWk74somG GR7PfwtWATistc3dXQWwO/j0mUTDCIMdD5hVTeX4l+Ski4+Wjv5R02c/Bar5CgneCKfsss n+AkM9pdMdi1lXHOxQqD1gZLXtA0ua/0D0kaD1DUq8C8HcrN3hW1TRiUrOwb+A== References: <20231218-pinephone-pll-fixes-v1-0-e238b6ed6dc1@oltmanns.dev> <13411739.uLZWGnKmhe@jernej-laptop> <87il4t9wi1.fsf@oltmanns.dev> <2174554.Mh6RI2rZIc@jernej-laptop> From: Frank Oltmanns To: Jernej =?utf-8?Q?=C5=A0krabec?= Subject: Re: [PATCH 4/5] clk: sunxi-ng: a64: Add constraints on PLL-VIDEO0's n/m ratio In-reply-to: <2174554.Mh6RI2rZIc@jernej-laptop> Date: Fri, 22 Dec 2023 08:46:01 +0100 Message-ID: <87edfellxi.fsf@oltmanns.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4SxK9d5hNTz9t37 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Purism Kernel Team , Samuel Holland , Stephen Boyd , David Airlie , Michael Turquette , linux-kernel@vger.kernel.org, Maxime Ripard , linux-clk@vger.kernel.org, linux-sunxi@lists.linux.dev, Chen-Yu Tsai , Ondrej Jirman , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Jessica Zhang , Sam Ravnborg , Guido =?utf-8?Q?G=C3=BCnther?= , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2023-12-20 at 16:12:42 +0100, Jernej =C5=A0krabec wrote: > Dne sreda, 20. december 2023 ob 08:09:28 CET je Frank Oltmanns napisal(a): >> >> On 2023-12-19 at 17:54:19 +0100, Jernej =C5=A0krabec wrote: >> > Dne ponedeljek, 18. december 2023 ob 14:35:22 CET je Frank Oltmanns na= pisal(a): >> >> The Allwinner A64 manual lists the following constraint for the >> >> PLL-VIDEO0 clock: 8 <=3D N/M <=3D 25 >> >> >> >> Use this constraint. >> >> >> >> Signed-off-by: Frank Oltmanns >> >> --- >> >> drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 8 ++++++-- >> >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> >> >> diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunx= i-ng/ccu-sun50i-a64.c >> >> index c034ac027d1c..75d839da446c 100644 >> >> --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> >> +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> >> @@ -68,7 +68,8 @@ static SUNXI_CCU_NM_WITH_SDM_GATE_LOCK(pll_audio_ba= se_clk, "pll-audio-base", >> >> BIT(28), /* lock */ >> >> CLK_SET_RATE_UNGATE); >> >> >> >> -static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST(pll_video0_c= lk, "pll-video0", >> >> +static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT_NM_RATIO(pll_vi= deo0_clk, >> >> + "pll-video0", >> >> "osc24M", 0x010, >> >> 192000000, /* Minimum rate */ >> >> 1008000000, /* Maximum rate */ >> >> @@ -80,7 +81,10 @@ static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CL= OSEST(pll_video0_clk, "pll-vid >> >> 297000000, /* frac rate 1 */ >> >> BIT(31), /* gate */ >> >> BIT(28), /* lock */ >> >> - CLK_SET_RATE_UNGATE); >> >> + CLK_SET_RATE_UNGATE, >> >> + CCU_FEATURE_FRACTIONAL | >> >> + CCU_FEATURE_CLOSEST_RATE, >> > >> > Above flags are unrelated change, put them in new patch if needed. >> >> You might notice that I am using a new macro for initializing the >> pll_video0_clk struct: >> New: SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT_NM_RATIO >> Old: SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST >> >> Setting the two CCU_FEATURE flags is part of the old initialization >> macro. >> >> I'll add SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_NM_RATIO_CLOSEST which >> hopefully resolves the confusion. > > I'm in doubt if we need so many macros. How many users of these macro we'= ll have? > I see that R40 SoC would also need same ratio limits, but other that that= , none? Ok, IIUC no additional macro and we keep this part of the patch as is. Best regards, Frank > > Best regards, > Jernej > >> >> Thanks, >> Frank >> >> > >> > Best regards, >> > Jernej >> > >> >> + 8, 25); /* min/max nm ratio */ >> >> >> >> static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK(pll_ve_clk, "pll-ve", >> >> "osc24M", 0x018, >> >> >> >> >>