From: Richard Palethorpe <rpalethorpe@suse.de>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] Refactor fork09 using new LTP API
Date: Thu, 02 Nov 2023 12:56:33 +0000 [thread overview]
Message-ID: <87edh8s3jf.fsf@suse.de> (raw)
In-Reply-To: <ZUJydZgdGTcPQAxt@yuki>
Hello,
Cyril Hrubis <chrubis@suse.cz> writes:
> Hi!
> Honestly I'm struggling to understand the point of this test, the
> description says:
>
> "Check that child has access to a full set of files"
>
> What is that supposed to mean? I guess that if we wanted to check that
> the child has inherited the file descriptors ee should open a few files,
> do some changes in the child/parent and check that they are not propagated to
> the other one. I.e. reading from a file in child/parent does not change
> file offset in parent. Closing a file descriptor from a child/parent
> does not close the file in the other one, etc.
This is what the fork10 rewrite does unless I am mistaken? So possibly
they can be combined.
fork12's description sugggests it does the same thing, but thhe test
just seems to test forking until a resource limit is hit. This overlaps
other tests and can probably be deleted.
>
> Also why do we use fopen() instead of just open()?
>
> --
> Cyril Hrubis
> chrubis@suse.cz
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-11-02 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 15:05 [LTP] [PATCH v1] Refactor fork09 using new LTP API Andrea Cervesato
2023-11-01 15:44 ` Cyril Hrubis
2023-11-02 12:52 ` Cyril Hrubis
2023-11-02 12:56 ` Richard Palethorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edh8s3jf.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.