Re: v6.1.y-dovetail-rebase

[Philippe Gerum <rpm@xenomai.org>]

Hi,

Jan Kiszka <jan.kiszka@siemens.com> writes:

> Hi Philippe,
>
> quick feedback on latest rebasing:
>
> https://source.denx.de/Xenomai/linux-dovetail/-/commit/8f155631c8b51731dfc2ae5145d4dcc68f2ed7ed
>
> This was likely accidentally folded, right?
>

It looks so. This conditional statement appeared upstream during the
v6.0 cycle it seems, and was unfortunately left unfixed in the dovetail
patch for this entire series.

> Furthermore, I will factor this change out into a separate commit in 
> merging v6.1.y-dovetail, for better traceability:
>
> diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
> index ce8bdd804bc7..c843bf352999 100644
> --- a/arch/x86/mm/fault.c
> +++ b/arch/x86/mm/fault.c
> @@ -1466,7 +1466,7 @@ void do_user_addr_fault(struct pt_regs *regs,
>  
>  	/* The fault is fully completed (including releasing mmap lock) */
>  	if (fault & VM_FAULT_COMPLETED)
> -		return;
> +		goto out;
>  
>  	/*
>  	 * If we need to retry the mmap_lock has already been released,
>
> To my understanding, this was a dovetail fix that applied to previous 
> versions as well.

Only to v6.0, however this series is not maintained dovetail-wise
anymore, so this stayed under the radar.

> Besides StackRot, another reason to update 6.1 soon.
>
> A tag on the new branch is still missing. I suspect you are still 
> testing? CI picked up the head already as well:
>

Yes, still in the process of testing the latest rebases on -stable for
5.10, 5.15, and 6.1 (armv8).

-- 
Philippe.