Re: b4: Feature-Request: use salted hash for change-id instead of descriptive-name when using b4 prep

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

Hi Johannes,

On lun., juin 05, 2023 at 08:10, Johannes Zink <j.zink@pengutronix.de> wrote:

> Hi Konstantin,
>
> On 6/2/23 18:50, Konstantin Ryabitsev wrote:
>> On Fri, Jun 02, 2023 at 10:00:11AM +0200, Johannes Zink wrote:
>>> Hi,
>
>>>[snip]
>>> I would like to ask if there is a possibility to change this to using a
>>> salted hash instead (salt is probably required due to rainbow table attacks)
>>> for messageID and changeID. If this would break some workflows, it could
>>> possibly be added as an optional command line argument for b4 prep?
>> 
>> I will consider this request. For now, you can manually edit the cover letter
>> commit to change the JSON bit there that records the change-id.
>
> thanks, that will definitely help for now, though it would be great to have it 
> supported natively in b4 prep.
>
>> 
>> E.g. right after you create a new b4-tracked branch using "b4 prep -n", you
>> can run "git commit --amend --allow-empty" and modify the change-id to be
>> whatever you like. Note, that you should only do this before you send out any
>> revisions.
>> 
>
> is that equivalent to do b4 prep --edit-cover?

No, it is not. b4 prep --edit-cover does not show the
"--- b4-submit-tracking ---" section that Konstantin recommended you to
edit.

You can only edit that with "git commit --amend --allow-empty"


>
> Johannes
>
>> -K
>> 
>
> -- 
> Pengutronix e.K.                | Johannes Zink                  |
> Steuerwalder Str. 21            | https://www.pengutronix.de/    |
> 31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
> Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |