From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ALSA: emu10k1: fix snd_emu1010_fpga_read() input masking for rev2 cards
Date: Sat, 22 Apr 2023 17:36:12 +0200 [thread overview]
Message-ID: <87edocoro3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230422132430.1057490-1-oswald.buddenhagen@gmx.de>
On Sat, 22 Apr 2023 15:24:30 +0200,
Oswald Buddenhagen wrote:
>
> Unlike the Alice2 chips used on 1st generation E-MU cards, the
> Tina/Tina2 chips used on the 2nd gen cards have only six GPIN pins,
> which means that we need to use a smaller mask. Failure to do so would
> falsify the read data if the FPGA tried to raise an IRQ right at that
> moment. This wasn't a problem so far, as we didn't actually enable FPGA
> IRQs, but that's going to change soon.
>
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
> ---
> v2:
> - added description
This is *MUCH* better and helpful to understand the changes.
Applied now. Thanks!
Takashi
prev parent reply other threads:[~2023-04-22 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 13:24 [PATCH v2] ALSA: emu10k1: fix snd_emu1010_fpga_read() input masking for rev2 cards Oswald Buddenhagen
2023-04-22 15:36 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edocoro3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=oswald.buddenhagen@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.