All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Leonardo Bras Soares Passos" <lsoaresp@redhat.com>,
	"David Hildenbrand" <david@redhat.com>
Subject: Re: [PATCH v2 1/4] util/mmap-alloc: qemu_fd_getfs()
Date: Wed, 19 Apr 2023 21:34:02 +0200	[thread overview]
Message-ID: <87edof1xat.fsf@secure.mitica> (raw)
In-Reply-To: <20230419161739.1129988-2-peterx@redhat.com> (Peter Xu's message of "Wed, 19 Apr 2023 12:17:36 -0400")

Peter Xu <peterx@redhat.com> wrote:
> This new helper fetches file system type for a fd.  Only Linux is
> implemented so far.  Currently only tmpfs and hugetlbfs is defined, but it

s/is/are/

> can grow per need.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

...

> +#include <linux/magic.h>

...

> +    case TMPFS_MAGIC:

...

> +    case HUGETLBFS_MAGIC:

Everybody loves magic, right? O:-)



  parent reply	other threads:[~2023-04-19 19:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 16:17 [PATCH v2 0/4] migration/hostmem: Allow to fail early for postcopy on specific fs type Peter Xu
2023-04-19 16:17 ` [PATCH v2 1/4] util/mmap-alloc: qemu_fd_getfs() Peter Xu
2023-04-19 16:31   ` David Hildenbrand
2023-04-19 19:34   ` Juan Quintela [this message]
2023-04-19 16:17 ` [PATCH v2 2/4] vl.c: Create late backends before migration object Peter Xu
2023-04-19 16:31   ` David Hildenbrand
2023-04-19 19:35   ` Juan Quintela
2023-04-19 16:17 ` [PATCH v2 3/4] migration/postcopy: Detect file system on dest host Peter Xu
2023-04-19 19:42   ` Juan Quintela
2023-04-19 16:17 ` [PATCH v2 4/4] migration: Allow postcopy_ram_supported_by_host() to report err Peter Xu
2023-04-19 19:51   ` Juan Quintela
2023-04-26  1:10     ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edof1xat.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=berrange@redhat.com \
    --cc=david@redhat.com \
    --cc=lsoaresp@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.