All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>, Joerg Roedel <joro@8bytes.org>,
	Tom Lendacky <thomas.lendacky@amd.com>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] x86/sev: Get rid of special sev_es_enable_key
Date: Thu, 23 Mar 2023 10:17:15 +0100	[thread overview]
Message-ID: <87edpf9690.ffs@tglx> (raw)
In-Reply-To: <20230318115634.9392-3-bp@alien8.de>

On Sat, Mar 18 2023 at 12:56, Borislav Petkov wrote:
> -bool cc_platform_has(enum cc_attr attr)
> +bool noinstr cc_platform_has(enum cc_attr attr)

That's not sufficient. This function invokes static functions which the
compiler can rightfully put out of line resulting in a noinstr violation.

Thanks,

        tglx

  reply	other threads:[~2023-03-23  9:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-18 11:56 [PATCH 0/2] SECC-ES: Cleanups Borislav Petkov
2023-03-18 11:56 ` [PATCH 1/2] x86/coco: Export cc_vendor Borislav Petkov
2023-03-28 12:59   ` [tip: x86/sev] " tip-bot2 for Borislav Petkov (AMD)
2023-03-30 10:09   ` [tip: x86/cc] " tip-bot2 for Borislav Petkov (AMD)
2023-03-30 12:12   ` tip-bot2 for Borislav Petkov (AMD)
2023-03-18 11:56 ` [PATCH 2/2] x86/sev: Get rid of special sev_es_enable_key Borislav Petkov
2023-03-23  9:17   ` Thomas Gleixner [this message]
2023-03-23  9:53     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edpf9690.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=bp@alien8.de \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.