From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B2ED8F4A for ; Wed, 22 Mar 2023 16:28:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679502490; x=1711038490; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=KfUvgiz4DVLzFaYO7oEOLPOOhMl2JyBbYso8oKRbz/4=; b=BmD8tCRaRZpZ/Kdpt6o8HriN434haTyWiJtpvtw3hoTNa3pS2V6r8eyp iWocqFWSGSK8IXOOk+qevIf4YHmkdHo55Ptn8/4MkvnJdL3r2xdpydXJ9 1M7Vw8JLqctqoOswdEw9Z3VdUUTs4AL4dHptPND7TMJFxBdLUUrA/luQO GJB1Rv9RDIfYcBFdCl07937y65CceZtts4jh1yucL4kgnJ5FBn0sWZUVQ AxIVQfbyXa54sWMjgYfVyFqeHechfdEXupJNEhVPbod58YmTwPQV78Dt3 fZxzEVYqQ2B5kxa4IzTYPT47vX7eQP4P/ybS7Jfbnbg88TGqBl4wAJfB7 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="339300030" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="339300030" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 09:28:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="771102926" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="771102926" Received: from jprokopo-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.61.221]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 09:27:59 -0700 From: Jani Nikula To: Andy Shevchenko , Pin-yen Lin Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck , Xin Ji , linux-kernel@vger.kernel.org, Thomas Zimmermann , linux-acpi@vger.kernel.org, Javier Martinez Canillas , AngeloGioacchino Del Regno , Hsin-Yi Wang , Lyude Paul , =?utf-8?Q?N=C3=ADco?= =?utf-8?Q?las_F_=2E_R_=2E_A_=2E_Prado?= , Allen Chen , dri-devel@lists.freedesktop.org, Marek Vasut , Stephen Boyd , chrome-platform@lists.linux.dev, devicetree@vger.kernel.org, Andi Shyti , Dmitry Baryshkov , Douglas Anderson , Imre Deak , Linus Walleij , YueHaibing Subject: Re: [PATCH v14 03/10] drm/display: Add Type-C switch helpers In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230322104639.221402-1-treapking@chromium.org> <20230322104639.221402-4-treapking@chromium.org> Date: Wed, 22 Mar 2023 18:27:56 +0200 Message-ID: <87edpg7nub.fsf@intel.com> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, 22 Mar 2023, Andy Shevchenko wrote: > On Wed, Mar 22, 2023 at 06:46:32PM +0800, Pin-yen Lin wrote: >> +#ifdef CONFIG_DRM_DISPLAY_DP_TYPEC_HELPER > > Ah, maybe this should use IS_REACHABLE() ? Personally, I think IS_REACHABLE() is a build-time band-aid solution to a problem that should be solved in Kconfig. :p I think it always means there's a configuration combo that shouldn't exist, and it's a surprise to the user when they've configured something, Kconfig has deemed it a valid configuration, but they don't get the feature they want. As a user, how would they even debug that case? Double check configs, don't see anything wrong. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79CC0C6FD1C for ; Wed, 22 Mar 2023 16:28:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2701610E352; Wed, 22 Mar 2023 16:28:12 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1797510E3C3 for ; Wed, 22 Mar 2023 16:28:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679502490; x=1711038490; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=KfUvgiz4DVLzFaYO7oEOLPOOhMl2JyBbYso8oKRbz/4=; b=BmD8tCRaRZpZ/Kdpt6o8HriN434haTyWiJtpvtw3hoTNa3pS2V6r8eyp iWocqFWSGSK8IXOOk+qevIf4YHmkdHo55Ptn8/4MkvnJdL3r2xdpydXJ9 1M7Vw8JLqctqoOswdEw9Z3VdUUTs4AL4dHptPND7TMJFxBdLUUrA/luQO GJB1Rv9RDIfYcBFdCl07937y65CceZtts4jh1yucL4kgnJ5FBn0sWZUVQ AxIVQfbyXa54sWMjgYfVyFqeHechfdEXupJNEhVPbod58YmTwPQV78Dt3 fZxzEVYqQ2B5kxa4IzTYPT47vX7eQP4P/ybS7Jfbnbg88TGqBl4wAJfB7 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="339300034" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="339300034" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 09:28:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="771102926" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="771102926" Received: from jprokopo-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.61.221]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 09:27:59 -0700 From: Jani Nikula To: Andy Shevchenko , Pin-yen Lin Subject: Re: [PATCH v14 03/10] drm/display: Add Type-C switch helpers In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230322104639.221402-1-treapking@chromium.org> <20230322104639.221402-4-treapking@chromium.org> Date: Wed, 22 Mar 2023 18:27:56 +0200 Message-ID: <87edpg7nub.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heikki Krogerus , Andrzej Hajda , "Rafael J . Wysocki" , dri-devel@lists.freedesktop.org, Douglas Anderson , Laurent Pinchart , Krzysztof Kozlowski , Guenter Roeck , Marek Vasut , chrome-platform@lists.linux.dev, Robert Foss , YueHaibing , Javier Martinez Canillas , Jernej Skrabec , linux-acpi@vger.kernel.org, Andi Shyti , devicetree@vger.kernel.org, Sakari Ailus , =?utf-8?Q?N=C3=ADco?= =?utf-8?Q?las_F_=2E_R_=2E_A_=2E_Prado?= , Jonas Karlman , Allen Chen , Stephen Boyd , Rob Herring , Hsin-Yi Wang , Xin Ji , AngeloGioacchino Del Regno , Neil Armstrong , Thomas Zimmermann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Daniel Scally , Prashant Malani , Dmitry Baryshkov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 22 Mar 2023, Andy Shevchenko wrote: > On Wed, Mar 22, 2023 at 06:46:32PM +0800, Pin-yen Lin wrote: >> +#ifdef CONFIG_DRM_DISPLAY_DP_TYPEC_HELPER > > Ah, maybe this should use IS_REACHABLE() ? Personally, I think IS_REACHABLE() is a build-time band-aid solution to a problem that should be solved in Kconfig. :p I think it always means there's a configuration combo that shouldn't exist, and it's a surprise to the user when they've configured something, Kconfig has deemed it a valid configuration, but they don't get the feature they want. As a user, how would they even debug that case? Double check configs, don't see anything wrong. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center