From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: From: Cornelia Huck In-Reply-To: References: <20230209121221.15118-1-mst@redhat.com> <20230209121221.15118-2-mst@redhat.com> Date: Mon, 13 Feb 2023 13:06:32 +0100 Message-ID: <87edqtdb1z.fsf@redhat.com> MIME-Version: 1.0 Subject: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH v10 01/10] virtio: document forward compatibility guarantees Content-Type: text/plain To: David Edmondson , "Michael S. Tsirkin" Cc: virtio-comment@lists.oasis-open.org, jasowang@redhat.com, sgarzare@redhat.com, stefanha@redhat.com, nrupal.jani@intel.com, Piotr.Uminski@intel.com, hang.yuan@intel.com, virtio@lists.oasis-open.org, Zhu Lingshan , pasic@linux.ibm.com, Shahaf Shuler , Parav Pandit , Max Gurtovoy , virtio-dev@lists.oasis-open.org List-ID: On Thu, Feb 09 2023, David Edmondson wrote: > On Thursday, 2023-02-09 at 07:13:32 -05, Michael S. Tsirkin wrote: >> +In particular, this is >> +especially important for features limited to specific transports, >> +as enabling these for more transports in future versions of the >> +specification is highly likely to require changing the behaviour >> +from drivers and devices. Drivers and devices supporting > > "changing the behaviour of" or "changed behaviour from" (prefer the > former). Agreed, I'd prefer the former as well. > >> +multiple transports need to carefully maintain per-transport >> +lists of allowed features. >> + >> \drivernormative{\subsection}{Feature Bits}{Basic Facilities of a Virtio Device / Feature Bits} >> The driver MUST NOT accept a feature which the device did not offer, >> and MUST NOT accept a feature which requires another feature which was >> not accepted. >> >> +The driver MUST validate the feature bits offered by the device. >> +The driver MUST ignore and MUST NOT accept any feature bit that is >> +\begin{itemize} >> +\item not described in this specification, >> +\item marked as reserved, >> +\item not supported for the specific transport, > > What does "supported" mean here? By the driver? By the specification in > respect of this transport? Maybe "not specified for the specific transport"? > >> +\item not defined for the device type. >> +\end{itemize} --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org