From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
qemu-ppc@nongnu.org, Eduardo Habkost <eduardo@habkost.net>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 5/9] hw/usb/hcd-ohci: Include missing 'sysbus.h' header
Date: Fri, 03 Feb 2023 13:33:33 +0100 [thread overview]
Message-ID: <87edr7c4iq.fsf@pond.sub.org> (raw)
In-Reply-To: <20230203113650.78146-6-philmd@linaro.org> ("Philippe Mathieu-Daudé"'s message of "Fri, 3 Feb 2023 12:36:46 +0100")
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> Avoid when including "hw/usb/hcd-ohci.h":
>
> hw/usb/hcd-ohci.h:100:5: error: unknown type name 'SysBusDevice'
> SysBusDevice parent_obj;
> ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/usb/hcd-ohci.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/usb/hcd-ohci.h b/hw/usb/hcd-ohci.h
> index 11ac57058d..e5e6b434fd 100644
> --- a/hw/usb/hcd-ohci.h
> +++ b/hw/usb/hcd-ohci.h
> @@ -21,6 +21,7 @@
> #ifndef HCD_OHCI_H
> #define HCD_OHCI_H
>
> +#include "hw/sysbus.h"
> #include "sysemu/dma.h"
> #include "hw/usb.h"
> #include "qom/object.h"
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2023-02-03 12:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 11:36 [PATCH 0/9] hw: Use QOM alias properties and few QOM/QDev cleanups Philippe Mathieu-Daudé
2023-02-03 11:36 ` [PATCH 1/9] hw/i386/sgx: Do not open-code qdev_realize_and_unref() Philippe Mathieu-Daudé
2023-02-03 12:32 ` Markus Armbruster
2023-02-03 13:15 ` Philippe Mathieu-Daudé
2023-02-03 13:36 ` Markus Armbruster
2023-02-03 11:36 ` [PATCH 2/9] hw/ppc/sam460ex: Correctly set MAL properties Philippe Mathieu-Daudé
2023-02-03 12:50 ` BALATON Zoltan
2023-02-03 11:36 ` [PATCH 3/9] hw/arm/nrf51: QOM-alias 'flash-size' property in SoC object Philippe Mathieu-Daudé
2023-02-03 11:36 ` [PATCH 4/9] hw/arm/fsl-imx: QOM-alias 'phy-num' " Philippe Mathieu-Daudé
2023-02-03 11:36 ` [PATCH 5/9] hw/usb/hcd-ohci: Include missing 'sysbus.h' header Philippe Mathieu-Daudé
2023-02-03 12:33 ` Markus Armbruster [this message]
2023-02-03 11:36 ` [PATCH 6/9] hw/display/sm501: QOM-alias 'dma-offset' property in chipset object Philippe Mathieu-Daudé
2023-02-03 13:05 ` BALATON Zoltan
2023-02-03 13:21 ` Philippe Mathieu-Daudé
2023-02-03 13:50 ` BALATON Zoltan
2023-02-03 14:11 ` Philippe Mathieu-Daudé
2023-02-03 14:12 ` BALATON Zoltan
2023-02-03 11:36 ` [PATCH 7/9] hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h' Philippe Mathieu-Daudé
2023-02-03 11:36 ` [PATCH 8/9] hw/mips: Declare all length properties as unsigned Philippe Mathieu-Daudé
2023-02-03 11:36 ` [RFC PATCH 9/9] hw/mips/itu: Pass SAAR using QOM link property Philippe Mathieu-Daudé
2023-02-13 14:01 ` Jiaxun Yang
2023-02-05 23:29 ` [PATCH 0/9] hw: Use QOM alias properties and few QOM/QDev cleanups Mark Cave-Ayland
2023-02-06 15:27 ` Philippe Mathieu-Daudé
2023-02-06 21:54 ` Mark Cave-Ayland
2023-02-06 23:04 ` Philippe Mathieu-Daudé
2023-02-07 20:35 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edr7c4iq.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=kraxel@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.