From: Tarun Sahu <tsahu@linux.ibm.com>
To: Petr Vorel <pvorel@suse.cz>, ltp@lists.linux.it
Cc: Richard Palethorpe <rpalethorpe@suse.com>
Subject: Re: [LTP] [PATCH 1/2] hugemmap15: Compile with -O
Date: Fri, 27 Jan 2023 02:35:09 +0530 [thread overview]
Message-ID: <87edrh0zy2.fsf@linux.ibm.com> (raw)
In-Reply-To: <20230125222703.19943-2-pvorel@suse.cz>
Hi Petr, Cyril, all
Though It already got merged, please note this,
IIRC, I specifically turned off optimization for hugemmap15
because of clang compiler issue, it behaves weirdly with clang
without -O0 and test fails on the system.
Petr Vorel <pvorel@suse.cz> writes:
> -O0 originally used causes warning on gcc 12:
>
> In file included from /usr/include/bits/libc-header-start.h:33,
> from /usr/include/stdio.h:27,
> from hugemmap15.c:22:
> /usr/include/features.h:412:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
> 412 | # warning _FORTIFY_SOURCE requires compiling with optimization (-O)
>
> Fixes: 15625f6185 ("Hugetlb: Migrating libhugetlbfs icache-hygiene")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/kernel/mem/hugetlb/hugemmap/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/mem/hugetlb/hugemmap/Makefile b/testcases/kernel/mem/hugetlb/hugemmap/Makefile
> index 6f10807cde..503a35f7f1 100644
> --- a/testcases/kernel/mem/hugetlb/hugemmap/Makefile
> +++ b/testcases/kernel/mem/hugetlb/hugemmap/Makefile
> @@ -8,5 +8,5 @@ include $(top_srcdir)/include/mk/testcases.mk
> include $(abs_srcdir)/../Makefile.inc
> include $(top_srcdir)/include/mk/generic_leaf_target.mk
>
> -hugemmap15: CFLAGS+=-O0
> +hugemmap15: CFLAGS+=-O
> hugemmap06: CFLAGS+=-pthread
> --
> 2.39.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-01-26 21:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 22:27 [LTP] [PATCH 0/2] hugemmap15 pre-release testing Petr Vorel
2023-01-25 22:27 ` [LTP] [PATCH 1/2] hugemmap15: Compile with -O Petr Vorel
2023-01-26 21:05 ` Tarun Sahu [this message]
2023-01-26 23:00 ` Petr Vorel
2023-01-26 23:38 ` Tarun Sahu
2023-01-27 8:28 ` Petr Vorel
2023-01-27 9:20 ` Cyril Hrubis
2023-02-10 22:04 ` Tarun Sahu
2023-02-10 22:33 ` [LTP] [PATCH] hugepage15: Resolve compile time warning generating with -O0 Tarun Sahu
2023-02-12 21:34 ` Petr Vorel
2023-02-13 15:29 ` Tarun Sahu
2023-02-13 15:26 ` [LTP] [PATCH v2] " Tarun Sahu
2023-02-13 17:26 ` Petr Vorel
2023-01-25 22:27 ` [LTP] [PATCH 2/2] hugemmap15.c: Use TST_TEST_TCONF() for unsupported archs Petr Vorel
2023-01-26 10:35 ` Cyril Hrubis
2023-01-26 10:36 ` Petr Vorel
2023-01-26 17:55 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edrh0zy2.fsf@linux.ibm.com \
--to=tsahu@linux.ibm.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.