From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75E2DC352A1 for ; Wed, 7 Dec 2022 12:24:34 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AAF8E1662; Wed, 7 Dec 2022 13:23:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AAF8E1662 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1670415871; bh=us+CAWNYN24Y/ZN9EAM8po4MTVmg74TvvD66n8PLdi4=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GxAcckglmNWfpnj43/DQ/E1ub6HwZfSzoqzhQKcHg3wrgVJdgOMsUjoLdLlOeoop8 bTAp0iHtphP6fyAvyeCmPZ/bozqpW8e2yYkHcJV/iQpwUlthDA3zum3MyjSjTaiR0t b3bLbubWS8TRAt4GG5ntb3zT9gwnkl656h/AxnLE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5DC4BF80169; Wed, 7 Dec 2022 13:23:41 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 89268F802BE; Wed, 7 Dec 2022 13:23:40 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7918CF80121 for ; Wed, 7 Dec 2022 13:23:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7918CF80121 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="LXOxhGYm"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+KVE59kQ" Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 778B61FD7A; Wed, 7 Dec 2022 12:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1670415813; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=loYT0A86SX2WIBPzHmVKDox+axk7EDHNAyPrWekbXbk=; b=LXOxhGYm+9p4++SMpgRnRsQ0WhtzKsYZv9OtR75NL6ZUB2ZCPtH386Hx82yf5OMup1DjQi f/OGvULMo7vhWSxuQQCbMsdJWIn4OKbD2xkpybA8hs+7+2rGSxjRkLLXnuq+57inILhuMm 888rt4TOJ2/j4eofilNkgAbaGgrw4y4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1670415813; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=loYT0A86SX2WIBPzHmVKDox+axk7EDHNAyPrWekbXbk=; b=+KVE59kQ2HWV0RFbHpBCAowJZUAFLd8rils8ooCiT3igCSRpStb5XfVSIckJur5y10jvHW 4GMyr98i4pocpXCw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 559E1134CD; Wed, 7 Dec 2022 12:23:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id TVtFFMWFkGNjSgAAGKfGzw (envelope-from ); Wed, 07 Dec 2022 12:23:33 +0000 Date: Wed, 07 Dec 2022 13:23:32 +0100 Message-ID: <87edtb8ksb.wl-tiwai@suse.de> From: Takashi Iwai To: edward-p Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Lenovo TianYi510Pro-14IOB In-Reply-To: <20221206180459.44260-1-edward@edward-p.xyz> References: <20221206180459.44260-1-edward@edward-p.xyz> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: Stefan Binding , Kailang Yang , Lucas Tanure , Meng Tang , Philipp Jungkamp , Tim Crawford , Takashi Iwai , Kai-Heng Feng , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 06 Dec 2022 19:04:58 +0100, edward-p wrote: > > Lenovo TianYi510Pro-14IOB (17aa:3742) > require quirk for enabling headset-mic > > Signed-off-by: edward-p > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216756 The code change looks OK, but the Signed-off-by line has to be with the real full name. As it's a legal requirement, it's mandatory. Could you correct and resubmit? thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12104C4708E for ; Wed, 7 Dec 2022 12:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229700AbiLGMXk (ORCPT ); Wed, 7 Dec 2022 07:23:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbiLGMXf (ORCPT ); Wed, 7 Dec 2022 07:23:35 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B87CF3C6CA for ; Wed, 7 Dec 2022 04:23:34 -0800 (PST) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 778B61FD7A; Wed, 7 Dec 2022 12:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1670415813; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=loYT0A86SX2WIBPzHmVKDox+axk7EDHNAyPrWekbXbk=; b=LXOxhGYm+9p4++SMpgRnRsQ0WhtzKsYZv9OtR75NL6ZUB2ZCPtH386Hx82yf5OMup1DjQi f/OGvULMo7vhWSxuQQCbMsdJWIn4OKbD2xkpybA8hs+7+2rGSxjRkLLXnuq+57inILhuMm 888rt4TOJ2/j4eofilNkgAbaGgrw4y4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1670415813; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=loYT0A86SX2WIBPzHmVKDox+axk7EDHNAyPrWekbXbk=; b=+KVE59kQ2HWV0RFbHpBCAowJZUAFLd8rils8ooCiT3igCSRpStb5XfVSIckJur5y10jvHW 4GMyr98i4pocpXCw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 559E1134CD; Wed, 7 Dec 2022 12:23:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id TVtFFMWFkGNjSgAAGKfGzw (envelope-from ); Wed, 07 Dec 2022 12:23:33 +0000 Date: Wed, 07 Dec 2022 13:23:32 +0100 Message-ID: <87edtb8ksb.wl-tiwai@suse.de> From: Takashi Iwai To: edward-p Cc: Jaroslav Kysela , Takashi Iwai , Stefan Binding , Tim Crawford , Meng Tang , Kai-Heng Feng , Lucas Tanure , Philipp Jungkamp , Kailang Yang , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Lenovo TianYi510Pro-14IOB In-Reply-To: <20221206180459.44260-1-edward@edward-p.xyz> References: <20221206180459.44260-1-edward@edward-p.xyz> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Dec 2022 19:04:58 +0100, edward-p wrote: > > Lenovo TianYi510Pro-14IOB (17aa:3742) > require quirk for enabling headset-mic > > Signed-off-by: edward-p > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216756 The code change looks OK, but the Signed-off-by line has to be with the real full name. As it's a legal requirement, it's mandatory. Could you correct and resubmit? thanks, Takashi