From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A78C1C433FE for ; Wed, 16 Nov 2022 17:09:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229536AbiKPRJv (ORCPT ); Wed, 16 Nov 2022 12:09:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232680AbiKPRJt (ORCPT ); Wed, 16 Nov 2022 12:09:49 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 833A7EE10; Wed, 16 Nov 2022 09:09:48 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1668618587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ikR02Krd2bWM7QtM03WkmIJ/tmd489mqo9OvnzkaC1Q=; b=r2dW5nSk/HYqTZyJyGMkOXClLUNOqcudAEPRXrxpFnk03pwPIVcCdDLlCkMSGXKWDV9fvj lypp8Awo66GzeAYe7ZRfdSL/G6D+Dhw981l7+zCad0KRsAKQTseh9A/gbJGRIldpYeWyMP xfMqgQzvESJ3zHARmKSkKHyllPHVVEzm6SsjIq68SXLibaoRSQsYY49wpjksmnahJT6fdP LcBPoBz1lwgJzXAYJlH0fK9/2fOeaUh37NeDH8SKKxayV0OG424QzFld2volH96KRIySGs +Ijs3J2xq76VquEuOuJfG6OFxh6m09wLhGTQ64uNq+mL6O8/I4cejDuFBIu/yg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1668618587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ikR02Krd2bWM7QtM03WkmIJ/tmd489mqo9OvnzkaC1Q=; b=Nzyh2lhLKe+ltyMNeDMuG9x97MhJd7Gn+M/8PLuEUjBxdTR4OlfnkSXmU8dl8u8Oj4LA6x d9VOzVCVE9sbLyCQ== To: Bjorn Helgaas Cc: LKML , x86@kernel.org, Joerg Roedel , Will Deacon , linux-pci@vger.kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Marc Zyngier , Greg Kroah-Hartman , Jason Gunthorpe , Dave Jiang , Alex Williamson , Kevin Tian , Dan Williams , Logan Gunthorpe , Ashok Raj , Jon Mason , Allen Hubbe , "Ahmed S. Darwish" , Reinette Chatre , Michael Ellerman , Christophe Leroy , linuxppc-dev@lists.ozlabs.org Subject: Re: [patch 27/39] PCI/MSI: Move pci_disable_msix() to api.c In-Reply-To: <20221116162617.GA1115753@bhelgaas> References: <20221116162617.GA1115753@bhelgaas> Date: Wed, 16 Nov 2022 18:09:46 +0100 Message-ID: <87edu2q10l.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Nov 16 2022 at 10:26, Bjorn Helgaas wrote: >> /** >> + * pci_disable_msix() - Disable MSI-X interrupt mode on device >> + * @dev: the PCI device to operate on >> + * >> + * Legacy device driver API to disable MSI-X interrupt mode on device, >> + * free earlier-allocated interrupt vectors, and restore INTx emulation. > > Isn't INTx *emulation* a PCIe implementation detail? Doesn't seem > relevant to callers that it's emulated. Don't know how the emulation ended up there. It restores INTx which is obvioulsy not a wire on PCIe... But yes, it's uninteresting. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 838D4C433FE for ; Wed, 16 Nov 2022 17:10:43 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NC8h20Mf4z3fBd for ; Thu, 17 Nov 2022 04:10:42 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=r2dW5nSk; dkim=fail reason="signature verification failed" header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=Nzyh2lhL; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linutronix.de (client-ip=2a0a:51c0:0:12e:550::1; helo=galois.linutronix.de; envelope-from=tglx@linutronix.de; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=r2dW5nSk; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=Nzyh2lhL; dkim-atps=neutral Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NC8g20xtjz2xVr for ; Thu, 17 Nov 2022 04:09:50 +1100 (AEDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1668618587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ikR02Krd2bWM7QtM03WkmIJ/tmd489mqo9OvnzkaC1Q=; b=r2dW5nSk/HYqTZyJyGMkOXClLUNOqcudAEPRXrxpFnk03pwPIVcCdDLlCkMSGXKWDV9fvj lypp8Awo66GzeAYe7ZRfdSL/G6D+Dhw981l7+zCad0KRsAKQTseh9A/gbJGRIldpYeWyMP xfMqgQzvESJ3zHARmKSkKHyllPHVVEzm6SsjIq68SXLibaoRSQsYY49wpjksmnahJT6fdP LcBPoBz1lwgJzXAYJlH0fK9/2fOeaUh37NeDH8SKKxayV0OG424QzFld2volH96KRIySGs +Ijs3J2xq76VquEuOuJfG6OFxh6m09wLhGTQ64uNq+mL6O8/I4cejDuFBIu/yg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1668618587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ikR02Krd2bWM7QtM03WkmIJ/tmd489mqo9OvnzkaC1Q=; b=Nzyh2lhLKe+ltyMNeDMuG9x97MhJd7Gn+M/8PLuEUjBxdTR4OlfnkSXmU8dl8u8Oj4LA6x d9VOzVCVE9sbLyCQ== To: Bjorn Helgaas Subject: Re: [patch 27/39] PCI/MSI: Move pci_disable_msix() to api.c In-Reply-To: <20221116162617.GA1115753@bhelgaas> References: <20221116162617.GA1115753@bhelgaas> Date: Wed, 16 Nov 2022 18:09:46 +0100 Message-ID: <87edu2q10l.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, Will Deacon , Lorenzo Pieralisi , Dave Jiang , Ashok Raj , Joerg Roedel , x86@kernel.org, Jason Gunthorpe , Allen Hubbe , Kevin Tian , "Ahmed S. Darwish" , Jon Mason , linuxppc-dev@lists.ozlabs.org, Alex Williamson , Bjorn Helgaas , Dan Williams , Reinette Chatre , Greg Kroah-Hartman , LKML , Marc Zyngier , Logan Gunthorpe Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Nov 16 2022 at 10:26, Bjorn Helgaas wrote: >> /** >> + * pci_disable_msix() - Disable MSI-X interrupt mode on device >> + * @dev: the PCI device to operate on >> + * >> + * Legacy device driver API to disable MSI-X interrupt mode on device, >> + * free earlier-allocated interrupt vectors, and restore INTx emulation. > > Isn't INTx *emulation* a PCIe implementation detail? Doesn't seem > relevant to callers that it's emulated. Don't know how the emulation ended up there. It restores INTx which is obvioulsy not a wire on PCIe... But yes, it's uninteresting.