From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5822CC433EF for ; Thu, 23 Jun 2022 08:39:34 +0000 (UTC) Received: from localhost ([::1]:56466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4INB-0001YX-4p for qemu-devel@archiver.kernel.org; Thu, 23 Jun 2022 04:39:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4ILk-0000oo-Fv for qemu-devel@nongnu.org; Thu, 23 Jun 2022 04:38:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34733) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4ILh-0005rg-C9 for qemu-devel@nongnu.org; Thu, 23 Jun 2022 04:38:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655973479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G3KDUPNs4GOD9r35pJws7dJWQV1LRF4eOd91hsrSjRQ=; b=eYYQVSnxaSR9mfy3BA6XQkViqTktja789KpfoZyx43vC0JYjRIcxFN4/kZSWYpDManx5yl VFe9r8UZVRX5VbTgfO0HkEULiW+i/j76hFb6D63uWLTDg9f0Bh37HvIGiPaYJivHi06CJl rQhpIzECSjvbUSpshmQseQCCcILbSm8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-138-UglUoWboPSuwkav12qbsRQ-1; Thu, 23 Jun 2022 04:37:56 -0400 X-MC-Unique: UglUoWboPSuwkav12qbsRQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 221C41C0690B; Thu, 23 Jun 2022 08:37:56 +0000 (UTC) Received: from localhost (unknown [10.39.194.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C8AB7456CD9; Thu, 23 Jun 2022 08:37:55 +0000 (UTC) From: Cornelia Huck To: Thomas Huth , qemu-s390x@nongnu.org, Christian Borntraeger , Eric Farman Cc: qemu-devel@nongnu.org Subject: Re: [PATCH 1/2] pc-bios/s390-ccw/virtio: Set missing status bits while initializing In-Reply-To: <20220623071131.412457-2-thuth@redhat.com> Organization: Red Hat GmbH References: <20220623071131.412457-1-thuth@redhat.com> <20220623071131.412457-2-thuth@redhat.com> User-Agent: Notmuch/0.36 (https://notmuchmail.org) Date: Thu, 23 Jun 2022 10:37:54 +0200 Message-ID: <87edzf93ml.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jun 23 2022, Thomas Huth wrote: > According chapter "3.1.1 Driver Requirements: Device Initialization" > of the Virtio specification (v1.1), a driver for a device has to set > the ACKNOWLEDGE and DRIVER bits in the status field after resetting > the device. The s390-ccw bios skipped these steps so far and seems > like QEMU never cared. Anyway, it's better to follow the spec, so > let's set these bits now in the right spots, too. > > Signed-off-by: Thomas Huth > --- > pc-bios/s390-ccw/virtio.c | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) The QEMU implementation seems to be pretty tolerant :) Reviewed-by: Cornelia Huck