From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3ECB5C433F5 for ; Thu, 12 May 2022 04:16:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8CBE710F08C; Thu, 12 May 2022 04:16:36 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id A877A10F08C for ; Thu, 12 May 2022 04:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652328995; x=1683864995; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=6JU52LbOK2ty8gv+0wuumaN/fz4NFq/m8predqs5jHo=; b=aa91+aSeEpV8dh3L1A9KQ35qVK6kL3kp4tNUYQCSFPCL2lO6hH9yZdz7 mjZnHOMOiOb9HBVYuUBxjNgJZAlI3knHZDCCptCyhCVDq7kRScw1gXLuy h0kV8/TYvrL9TsZIXBX+OilJ3JgnaC8EvCdkYbdWqyl58a5e/0ntXqPKj L8CSNu4b0A51I6vlx1wBtvOeyFkeWI9dQ1K0XK4qjyZ1k94KhSTQkJSPz +xiPYEnHzpK3JD0BalQ3vbGHXdnkv1+hvLRs3Nhwd78IgRrgahAqrdlt7 dCDNP6dGZivaRlItxKup7LihhJbk+3b8CuChQu6w/EV43hEkQsFSND/Di g==; X-IronPort-AV: E=McAfee;i="6400,9594,10344"; a="249779370" X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="249779370" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 21:16:34 -0700 X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="636687281" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.252.130.105]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 21:16:34 -0700 Date: Wed, 11 May 2022 21:16:33 -0700 Message-ID: <87ee0z75cu.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Anshuman Gupta In-Reply-To: <20220511130455.22028-1-anshuman.gupta@intel.com> References: <20220511130455.22028-1-anshuman.gupta@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915: Use drm_dbg for rpm logging X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 11 May 2022 06:04:54 -0700, Anshuman Gupta wrote: > > RPM suspend/resume also supported on gfx platforms which doesn't have > kms support and even on platforms without any connected display panel. > There is no good reason to log rpm suspend/resume debug message with > drm_dbg_kms() therefore changing it to drm_dbg(). Reviewed-by: Ashutosh Dixit > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/i915_driver.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c > index 90b0ce5051af..ed6028fd442d 100644 > --- a/drivers/gpu/drm/i915/i915_driver.c > +++ b/drivers/gpu/drm/i915/i915_driver.c > @@ -1549,7 +1549,7 @@ static int intel_runtime_suspend(struct device *kdev) > if (drm_WARN_ON_ONCE(&dev_priv->drm, !HAS_RUNTIME_PM(dev_priv))) > return -ENODEV; > > - drm_dbg_kms(&dev_priv->drm, "Suspending device\n"); > + drm_dbg(&dev_priv->drm, "Suspending device\n"); > > disable_rpm_wakeref_asserts(rpm); > > @@ -1625,7 +1625,7 @@ static int intel_runtime_suspend(struct device *kdev) > if (!IS_VALLEYVIEW(dev_priv) && !IS_CHERRYVIEW(dev_priv)) > intel_hpd_poll_enable(dev_priv); > > - drm_dbg_kms(&dev_priv->drm, "Device suspended\n"); > + drm_dbg(&dev_priv->drm, "Device suspended\n"); > return 0; > } > > @@ -1639,7 +1639,7 @@ static int intel_runtime_resume(struct device *kdev) > if (drm_WARN_ON_ONCE(&dev_priv->drm, !HAS_RUNTIME_PM(dev_priv))) > return -ENODEV; > > - drm_dbg_kms(&dev_priv->drm, "Resuming device\n"); > + drm_dbg(&dev_priv->drm, "Resuming device\n"); > > drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm->wakeref_count)); > disable_rpm_wakeref_asserts(rpm); > @@ -1683,7 +1683,7 @@ static int intel_runtime_resume(struct device *kdev) > drm_err(&dev_priv->drm, > "Runtime resume failed, disabling it (%d)\n", ret); > else > - drm_dbg_kms(&dev_priv->drm, "Device resumed\n"); > + drm_dbg(&dev_priv->drm, "Device resumed\n"); > > return ret; > } > -- > 2.26.2 >