All of lore.kernel.org
 help / color / mirror / Atom feed
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/serial: scif: add support for HSCIF
Date: Thu, 27 Jan 2022 17:18:52 +0000	[thread overview]
Message-ID: <87ee4tgkr3.fsf@epam.com> (raw)
In-Reply-To: <20220127170008.271723-1-volodymyr_babchuk@epam.com>


Hi Julien, Bertrand,

Sorry, I messed up with your e-mail addresses in the previous
email. Adding you correctly. 

Volodymyr Babchuk <volodymyr_babchuk@epam.com> writes:

> HSCIF is a high-speed variant of Renesas SCIF serial interface. From
> Xen point of view, they almost the same, only difference is in FIFO
> size.
>
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> ---
>  xen/drivers/char/scif-uart.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c
> index ee204a11a4..8f4485bdfc 100644
> --- a/xen/drivers/char/scif-uart.c
> +++ b/xen/drivers/char/scif-uart.c
> @@ -47,6 +47,7 @@ enum port_types
>  {
>      SCIF_PORT,
>      SCIFA_PORT,
> +    HSCIF_PORT,
>      NR_PORTS,
>  };
>  
> @@ -88,6 +89,17 @@ static const struct port_params port_params[NR_PORTS] =
>                          SCASCR_BRIE,
>          .fifo_size    = 64,
>      },
> +    [HSCIF_PORT] =
> +    {
> +        .status_reg   = SCIF_SCFSR,
> +        .tx_fifo_reg  = SCIF_SCFTDR,
> +        .rx_fifo_reg  = SCIF_SCFRDR,
> +        .overrun_reg  = SCIF_SCLSR,
> +        .overrun_mask = SCLSR_ORER,
> +        .error_mask   = SCFSR_PER | SCFSR_FER | SCFSR_BRK | SCFSR_ER,
> +        .irq_flags    = SCSCR_RIE | SCSCR_TIE | SCSCR_REIE,
> +        .fifo_size    = 128,
> +    },
>  };
>  
>  static void scif_uart_interrupt(int irq, void *data, struct cpu_user_regs *regs)
> @@ -288,6 +300,7 @@ static const struct dt_device_match scif_uart_dt_match[] __initconst =
>  {
>      { .compatible = "renesas,scif",  .data = &port_params[SCIF_PORT] },
>      { .compatible = "renesas,scifa", .data = &port_params[SCIFA_PORT] },
> +    { .compatible = "renesas,hscif", .data = &port_params[HSCIF_PORT] },
>      { /* sentinel */ },
>  };


-- 
Volodymyr Babchuk at EPAM

       reply	other threads:[~2022-01-27 17:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220127170008.271723-1-volodymyr_babchuk@epam.com>
2022-01-27 17:18 ` Volodymyr Babchuk [this message]
2022-01-27 19:24   ` [PATCH] xen/serial: scif: add support for HSCIF Oleksandr
2022-02-08 11:23 Volodymyr Babchuk
2022-02-09 12:25 ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee4tgkr3.fsf@epam.com \
    --to=volodymyr_babchuk@epam.com \
    --cc=Oleksandr_Tyshchenko@epam.com \
    --cc=bertrand.marquis@arm.com \
    --cc=julien@xen.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.