All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Xu Zheng <xuzheng@cmss.chinamobile.com>
Cc: dgilbert@redhat.com,
	Mao Zhongyi <maozhongyi@cmss.chinamobile.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] migration/ram: clean up unused comment.
Date: Wed, 26 Jan 2022 22:00:37 +0100	[thread overview]
Message-ID: <87ee4unrey.fsf@secure.mitica> (raw)
In-Reply-To: <20220117023003.1655917-1-xuzheng@cmss.chinamobile.com> (Xu Zheng's message of "Mon, 17 Jan 2022 10:30:03 +0800")

Xu Zheng <xuzheng@cmss.chinamobile.com> wrote:
> Just a removal of an unused comment.
> a0a8aa147aa did many fixes and removed the parameter named "ms", but
> forget to remove the corresponding comment in function named
> "ram_save_host_page".
>
> Signed-off-by: Xu Zheng <xuzheng@cmss.chinamobile.com>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

queued.

> ---
>  migration/ram.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 57efa67f20..96944f0c70 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -2188,7 +2188,6 @@ static int ram_save_target_page(RAMState *rs, PageSearchStatus *pss,

Somehow git diff got confised here, and shows ram_save_target_page where
it is ram_save_host_page().  I fixued it manually.


>   * Returns the number of pages written or negative on error
>   *
>   * @rs: current RAM state
> - * @ms: current migration state
>   * @pss: data about the page we want to send
>   * @last_stage: if we are at the completion stage
>   */



      reply	other threads:[~2022-01-26 21:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17  2:30 [PATCH] migration/ram: clean up unused comment Xu Zheng
2022-01-26 21:00 ` Juan Quintela [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee4unrey.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=maozhongyi@cmss.chinamobile.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xuzheng@cmss.chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.