From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20B9CC4332F for ; Fri, 17 Dec 2021 17:23:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239852AbhLQRXD convert rfc822-to-8bit (ORCPT ); Fri, 17 Dec 2021 12:23:03 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:57571 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239847AbhLQRXD (ORCPT ); Fri, 17 Dec 2021 12:23:03 -0500 Received: (Authenticated sender: gregory.clement@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id DAD12200008; Fri, 17 Dec 2021 17:23:00 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Stephen Boyd Cc: Michael Turquette , Rob Herring , Greg Kroah-Hartman , Andrew Lunn , Sebastian Hesselbarth , Vladimir Vid , Marek =?utf-8?Q?Beh=C3=BAn?= , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 0/6] serial: mvebu-uart: Support for higher baudrates In-Reply-To: <20211103214209.azo2z3z4gy7aj5hu@pali> References: <20210930095838.28145-1-pali@kernel.org> <20211103214209.azo2z3z4gy7aj5hu@pali> Date: Fri, 17 Dec 2021 18:23:00 +0100 Message-ID: <87ee6bm9hn.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hello Pali, > On Thursday 30 September 2021 11:58:32 Pali Rohár wrote: >> This patch series add support for baudrates higher than 230400 on >> Marvell Armada 37xx boards. > > Stephen, Gregory, are there any issues with this patch series? I am not found of these changes but let's apply it as I didn't take time to do a better review. However I can't apply the dt part if the driver is not merged. Gregory > If not, could you take them? > >> Changes in v7: >> * fixed lint errors in yaml binding file >> >> Changes in v6: >> * fixed yaml binding file and dts files >> >> Changes in v5: >> * fixed yaml binding file >> >> Changes in v4: >> * converted armada3700-uart-clock documentation to YAML >> * split documentation changes into two commits: >> - first which adds clock documentation >> - second which updates UART documentation >> >> Changes in v3: >> v3 is rebased on top of Linus master branch and all already applied patches >> were dropped. There are no changes in patches itself since v2. >> >> Pali Rohár (6): >> math64: New DIV_U64_ROUND_CLOSEST helper >> serial: mvebu-uart: implement UART clock driver for configuring UART >> base clock >> dt-bindings: mvebu-uart: document DT bindings for >> marvell,armada-3700-uart-clock >> dt-bindings: mvebu-uart: update information about UART clock >> arm64: dts: marvell: armada-37xx: add device node for UART clock and >> use it >> serial: mvebu-uart: implement support for baudrates higher than 230400 >> >> .../clock/marvell,armada-3700-uart-clock.yaml | 59 ++ >> .../devicetree/bindings/serial/mvebu-uart.txt | 9 +- >> arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 14 +- >> drivers/tty/serial/Kconfig | 1 + >> drivers/tty/serial/mvebu-uart.c | 592 +++++++++++++++++- >> include/linux/math64.h | 13 + >> 6 files changed, 667 insertions(+), 21 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/clock/marvell,armada-3700-uart-clock.yaml >> >> -- >> 2.20.1 >> -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E672C433F5 for ; Fri, 17 Dec 2021 18:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qkCRVfKifdMbdben3BjuvZcFGw7wvzvM2Xx9DERIm7Y=; b=IJokmvzo0oA9Ea j2QHKvYC64VJiNwxP8o+e23+l6Q/eowpobwrYx71XTBqDZtWcSbr8iEKsKchqpWr9fPBJu4Inm0I5 SFxk7JfUzEu3WCpEn/4vEXsiPWhkzfMHG9eBP+yYj5vG++1029TYXj8HULES+Xws5SOqrpYRYIRpv Ua7eRAf00Ly74C08hFAYb/xKFKO0IBFh0S7fauTkQpig8v8tHRI5xKowXU9vf5CNrqY62xjR/mWHL HcpJi0ycyha9fabPADqzvpE7Ykk0yZQxptsWSnSExdJeC9jPaC+VH4yOdNHOoje6TfVxJQlSKqCKU aW5IEJgJKikYUFKLbhlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1myHo4-00Bl93-JR; Fri, 17 Dec 2021 18:18:13 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1myGwn-00BSg9-Qs for linux-arm-kernel@lists.infradead.org; Fri, 17 Dec 2021 17:23:14 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id DAD12200008; Fri, 17 Dec 2021 17:23:00 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Stephen Boyd Cc: Michael Turquette , Rob Herring , Greg Kroah-Hartman , Andrew Lunn , Sebastian Hesselbarth , Vladimir Vid , Marek =?utf-8?Q?Beh=C3=BAn?= , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 0/6] serial: mvebu-uart: Support for higher baudrates In-Reply-To: <20211103214209.azo2z3z4gy7aj5hu@pali> References: <20210930095838.28145-1-pali@kernel.org> <20211103214209.azo2z3z4gy7aj5hu@pali> Date: Fri, 17 Dec 2021 18:23:00 +0100 Message-ID: <87ee6bm9hn.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211217_092310_075809_BACCC579 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gUGFsaSwKCj4gT24gVGh1cnNkYXkgMzAgU2VwdGVtYmVyIDIwMjEgMTE6NTg6MzIgUGFs aSBSb2jDoXIgd3JvdGU6Cj4+IFRoaXMgcGF0Y2ggc2VyaWVzIGFkZCBzdXBwb3J0IGZvciBiYXVk cmF0ZXMgaGlnaGVyIHRoYW4gMjMwNDAwIG9uCj4+IE1hcnZlbGwgQXJtYWRhIDM3eHggYm9hcmRz Lgo+Cj4gU3RlcGhlbiwgR3JlZ29yeSwgYXJlIHRoZXJlIGFueSBpc3N1ZXMgd2l0aCB0aGlzIHBh dGNoIHNlcmllcz8KCkkgYW0gbm90IGZvdW5kIG9mIHRoZXNlIGNoYW5nZXMgYnV0IGxldCdzIGFw cGx5IGl0IGFzIEkgZGlkbid0IHRha2UgdGltZQp0byBkbyBhIGJldHRlciByZXZpZXcuCgpIb3dl dmVyIEkgY2FuJ3QgYXBwbHkgdGhlIGR0IHBhcnQgaWYgdGhlIGRyaXZlciBpcyBub3QgbWVyZ2Vk LgoKR3JlZ29yeQoKPiBJZiBub3QsIGNvdWxkIHlvdSB0YWtlIHRoZW0/Cj4KPj4gQ2hhbmdlcyBp biB2NzoKPj4gKiBmaXhlZCBsaW50IGVycm9ycyBpbiB5YW1sIGJpbmRpbmcgZmlsZQo+PiAKPj4g Q2hhbmdlcyBpbiB2NjoKPj4gKiBmaXhlZCB5YW1sIGJpbmRpbmcgZmlsZSBhbmQgZHRzIGZpbGVz Cj4+IAo+PiBDaGFuZ2VzIGluIHY1Ogo+PiAqIGZpeGVkIHlhbWwgYmluZGluZyBmaWxlCj4+IAo+ PiBDaGFuZ2VzIGluIHY0Ogo+PiAqIGNvbnZlcnRlZCBhcm1hZGEzNzAwLXVhcnQtY2xvY2sgZG9j dW1lbnRhdGlvbiB0byBZQU1MCj4+ICogc3BsaXQgZG9jdW1lbnRhdGlvbiBjaGFuZ2VzIGludG8g dHdvIGNvbW1pdHM6Cj4+ICAgLSBmaXJzdCB3aGljaCBhZGRzIGNsb2NrIGRvY3VtZW50YXRpb24K Pj4gICAtIHNlY29uZCB3aGljaCB1cGRhdGVzIFVBUlQgZG9jdW1lbnRhdGlvbgo+PiAKPj4gQ2hh bmdlcyBpbiB2MzoKPj4gdjMgaXMgcmViYXNlZCBvbiB0b3Agb2YgTGludXMgbWFzdGVyIGJyYW5j aCBhbmQgYWxsIGFscmVhZHkgYXBwbGllZCBwYXRjaGVzCj4+IHdlcmUgZHJvcHBlZC4gVGhlcmUg YXJlIG5vIGNoYW5nZXMgaW4gcGF0Y2hlcyBpdHNlbGYgc2luY2UgdjIuCj4+IAo+PiBQYWxpIFJv aMOhciAoNik6Cj4+ICAgbWF0aDY0OiBOZXcgRElWX1U2NF9ST1VORF9DTE9TRVNUIGhlbHBlcgo+ PiAgIHNlcmlhbDogbXZlYnUtdWFydDogaW1wbGVtZW50IFVBUlQgY2xvY2sgZHJpdmVyIGZvciBj b25maWd1cmluZyBVQVJUCj4+ICAgICBiYXNlIGNsb2NrCj4+ICAgZHQtYmluZGluZ3M6IG12ZWJ1 LXVhcnQ6IGRvY3VtZW50IERUIGJpbmRpbmdzIGZvcgo+PiAgICAgbWFydmVsbCxhcm1hZGEtMzcw MC11YXJ0LWNsb2NrCj4+ICAgZHQtYmluZGluZ3M6IG12ZWJ1LXVhcnQ6IHVwZGF0ZSBpbmZvcm1h dGlvbiBhYm91dCBVQVJUIGNsb2NrCj4+ICAgYXJtNjQ6IGR0czogbWFydmVsbDogYXJtYWRhLTM3 eHg6IGFkZCBkZXZpY2Ugbm9kZSBmb3IgVUFSVCBjbG9jayBhbmQKPj4gICAgIHVzZSBpdAo+PiAg IHNlcmlhbDogbXZlYnUtdWFydDogaW1wbGVtZW50IHN1cHBvcnQgZm9yIGJhdWRyYXRlcyBoaWdo ZXIgdGhhbiAyMzA0MDAKPj4gCj4+ICAuLi4vY2xvY2svbWFydmVsbCxhcm1hZGEtMzcwMC11YXJ0 LWNsb2NrLnlhbWwgfCAgNTkgKysKPj4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NlcmlhbC9t dmVidS11YXJ0LnR4dCB8ICAgOSArLQo+PiAgYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2Fy bWFkYS0zN3h4LmR0c2kgIHwgIDE0ICstCj4+ICBkcml2ZXJzL3R0eS9zZXJpYWwvS2NvbmZpZyAg ICAgICAgICAgICAgICAgICAgfCAgIDEgKwo+PiAgZHJpdmVycy90dHkvc2VyaWFsL212ZWJ1LXVh cnQuYyAgICAgICAgICAgICAgIHwgNTkyICsrKysrKysrKysrKysrKysrLQo+PiAgaW5jbHVkZS9s aW51eC9tYXRoNjQuaCAgICAgICAgICAgICAgICAgICAgICAgIHwgIDEzICsKPj4gIDYgZmlsZXMg Y2hhbmdlZCwgNjY3IGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQo+PiAgY3JlYXRlIG1v ZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9jbG9jay9tYXJ2ZWxs LGFybWFkYS0zNzAwLXVhcnQtY2xvY2sueWFtbAo+PiAKPj4gLS0gCj4+IDIuMjAuMQo+PiAKCi0t IApHcmVnb3J5IENsZW1lbnQsIEJvb3RsaW4KRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdp bmVlcmluZwpodHRwOi8vYm9vdGxpbi5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK