Re: [PATCH v2] ath10k: fetch (pre-)calibration data via nvmem subsystem

From: Kalle Valo <kvalo@codeaurora.org>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: linux-wireless@vger.kernel.org,  ath10k@lists.infradead.org
Subject: Re: [PATCH v2] ath10k: fetch (pre-)calibration data via nvmem subsystem
Date: Thu, 28 Oct 2021 11:58:13 +0300	[thread overview]
Message-ID: <87ee855xwa.fsf@codeaurora.org> (raw)
In-Reply-To: <20211016234609.1568317-1-chunkeey@gmail.com> (Christian Lamparter's message of "Sun, 17 Oct 2021 01:46:09 +0200")

Christian Lamparter <chunkeey@gmail.com> writes:

> ATH10K chips are used it wide range of routers,
> accesspoints, range extenders, network appliances.
> On these embedded devices, calibration data is often
> stored on the main system's flash and was out of reach
> for the driver.
>
> To bridge this gap, ath10k is getting extended to pull
> the (pre-)calibration data through nvmem subsystem.
> To do this, a nvmem-cell containing the information can
> either be specified in the platform data or via device-tree.
>
> Tested with:
>         Netgear EX6150v2 (IPQ4018 - pre-calibration method)
>         TP-Link Archer C7 v2 (QCA9880v2 - old calibration method)
>
> Cc: Robert Marko <robimarko@gmail.com>
> Cc: Thibaut VARÈNE <hacks@slashdirt.org>
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
> ---
>
> v1 -> v2:
> 	- use %zu and %u in the format string for size_t
>           and u32 types (catched by the "kernel test robot").
> 	- reworded commit message + successfully tested on QCA9880v2
>
> I placed the nvmem code in front of the current "file" method
> (firmware_request). Reason is that this makes it easier for me
> to test it. If needed it can be moved to a different place.

Looks good to me. Before I apply this, I want to mention to that I have
had a long in my deferred queue related two patchsets:

https://patchwork.kernel.org/project/linux-wireless/patch/20200927192515.86-1-ansuelsmth@gmail.com/
https://patchwork.kernel.org/project/linux-wireless/patch/20200927192515.86-2-ansuelsmth@gmail.com/

https://patchwork.kernel.org/project/linux-wireless/patch/20200918181104.98-1-ansuelsmth@gmail.com/
https://patchwork.kernel.org/project/linux-wireless/patch/20200918181104.98-2-ansuelsmth@gmail.com/

Christian, we don't need those anymore, right? Expect the first patch
maybe.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k