From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mY7ur-0004Qx-69 for mharc-grub-devel@gnu.org; Wed, 06 Oct 2021 10:29:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY7uo-0004LW-TS for grub-devel@gnu.org; Wed, 06 Oct 2021 10:29:02 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:52738) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY7um-0003Ei-49 for grub-devel@gnu.org; Wed, 06 Oct 2021 10:29:02 -0400 Received: from frontend02.mail.m-online.net (unknown [192.168.8.183]) by mail-out.m-online.net (Postfix) with ESMTP id 4HPcJj6DpCz1s8dB; Wed, 6 Oct 2021 16:28:53 +0200 (CEST) Received: from localhost (dynscan2.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4HPcJj4d7Cz1qqkK; Wed, 6 Oct 2021 16:28:53 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan2.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id OplwNzPWiEIj; Wed, 6 Oct 2021 16:28:52 +0200 (CEST) X-Auth-Info: 8+EvoQONvFHxtF5LT2Rvx4ScdUCG7fRotxv8hMrQ08VRX+8VUSURwLVYGp7aA6eK Received: from igel.home (ppp-46-244-184-42.dynamic.mnet-online.de [46.244.184.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 6 Oct 2021 16:28:52 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id B0ACA2C28AD; Wed, 6 Oct 2021 16:28:51 +0200 (CEST) From: Andreas Schwab To: Heinrich Schuchardt Cc: Daniel Kiper , Andrei Borzenkov , Vladimir 'phcoder' Serbinenko , Nikita Ermakov , Ard Biesheuvel , Atish Patra , Leif Lindholm , GRUB development mailing list Subject: Re: [PATCH 0/2] efinet: correct closing of SNP protocol References: <20211006083043.9313-1-heinrich.schuchardt@canonical.com> X-Yow: Now my EMOTIONAL RESOURCES are heavily committed to 23% of the SMELTING and REFINING industry of the state of NEVADA!! Date: Wed, 06 Oct 2021 16:28:51 +0200 In-Reply-To: <20211006083043.9313-1-heinrich.schuchardt@canonical.com> (Heinrich Schuchardt's message of "Wed, 6 Oct 2021 10:30:41 +0200") Message-ID: <87ee8yb524.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=212.18.0.10; envelope-from=whitebox@nefkom.net; helo=mail-out.m-online.net X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2021 14:29:03 -0000 On Okt 06 2021, Heinrich Schuchardt wrote: > In the context of the implementation of the EFI_LOAD_FILE2_PROTOCOL for > the initial ramdisk it was observed that opening the SNP protocol failed > (https://lists.gnu.org/archive/html/grub-devel/2021-10/msg00020.html). > This is due to an incorrect call to CloseProtocol(). > > This is corrected in the first patch. > > The second patch provides a new function grub_efi_close_protocol() to > simplify the coding. Sucessfully tested with https://download.opensuse.org/ports/riscv/tumbleweed/iso/openSUSE-Tumbleweed-NET-riscv64-Media.iso on the Hifive Unmatched. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."